-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A11y kibana overview test - changed the order of the tests being run. #90876
A11y kibana overview test - changed the order of the tests being run. #90876
Conversation
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1273/ ( flaky test runner ) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1283/ - flaky test runner run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We should wait for lens fix to get in and review before merging.
@rashmivkulkarni I was thinking about this & we actually don't need to install sample data in accessibility/kibana_overview.ts because we are testing that part in accessibility/home.ts where it passes. So Rashmi's skipped a11y test fix can either delete that piece of code or merge this part into home.ts " await PageObjects.common.navigateToApp('kibanaOverview');" |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Have taken out adding/removal of sample data test out of this file as it was already covered in |
Pinging @elastic/kibana-core (Team:Core) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@bhavyarm - second review please. |
LGTM @rashmivkulkarni thanks! |
…elastic#90876) * fixes elastic#74449 * changed the order of the tests * removed a test as it was already covered in home.ts and reoved sampledata Co-authored-by: Kibana Machine <[email protected]>
…#90876) (#91681) * fixes #74449 * changed the order of the tests * removed a test as it was already covered in home.ts and reoved sampledata Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Fixes: #82226 (comment)