Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility test- unskipping a functional test (kibana_overview.ts) #90395

Merged
merged 13 commits into from
Feb 5, 2021
Merged

Accessibility test- unskipping a functional test (kibana_overview.ts) #90395

merged 13 commits into from
Feb 5, 2021

Conversation

rashmivkulkarni
Copy link
Contributor

@rashmivkulkarni rashmivkulkarni commented Feb 5, 2021 •
edited
Loading

Fixes #82226

This test passed continuously 50 times in a row locally.

@rashmivkulkarni rashmivkulkarni self-assigned this Feb 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

myasonik
myasonik approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I mean, I'm happy to merge this if it passes but it does seem weird that it was flaky but now it isn't with no changes...

@mistic how concerned should we be about that?

@rashmivkulkarni
Copy link
Contributor Author

Flaky test runner build: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1247/

bhavyarm
bhavyarm approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rashmivkulkarni rashmivkulkarni merged commit 3ba3131 into elastic:master Feb 5, 2021
This was referenced Feb 5, 2021
Closed
Merged
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Feb 5, 2021
@rashmivkulkarni
Accessibility test- unskipping a functional test (kibana_overview.ts) (…
646e731 
…elastic#90395)

* fixes elastic#74449

* unskipping accessibility test
rashmivkulkarni added a commit that referenced this pull request Feb 5, 2021
@rashmivkulkarni
Accessibility test- unskipping a functional test (kibana_overview.ts) (…
517e46e 
…#90395) (#90493)

* fixes #74449

* unskipping accessibility test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhavyarm bhavyarm bhavyarm approved these changes

@myasonik myasonik myasonik approved these changes

Assignees

@rashmivkulkarni rashmivkulkarni

Labels
automation Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@rashmivkulkarni @elasticmachine @kibanamachine @myasonik @bhavyarm