Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport unskip management test #90340

Closed
wants to merge 13 commits into from
Closed

Backport unskip management test #90340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f3fc995
fixes https://github.com/elastic/kibana/issues/74449
rashmivkulkarni Oct 20, 2020
411da9a
Merge branch 'master' of github.com:elastic/kibana
rashmivkulkarni Jan 18, 2021
154ce17
Merge branch 'master' of github.com:elastic/kibana
rashmivkulkarni Jan 22, 2021
a1783d8
Merge branch 'master' of github.com:elastic/kibana
rashmivkulkarni Jan 25, 2021
04de479
Merge branch 'master' of github.com:elastic/kibana
rashmivkulkarni Jan 27, 2021
cd06932
Merge branch 'master' of github.com:elastic/kibana
rashmivkulkarni Jan 28, 2021
50550f6
Merge branch 'master' of github.com:elastic/kibana
rashmivkulkarni Jan 28, 2021
ee59795
Merge branch 'master' of github.com:elastic/kibana
rashmivkulkarni Jan 29, 2021
2707fa3
Merge branch 'master' of github.com:elastic/kibana
rashmivkulkarni Feb 2, 2021
645d38c
Merge branch 'master' of github.com:elastic/kibana
rashmivkulkarni Feb 2, 2021
f2e4413
Merge branch 'master' of github.com:elastic/kibana
rashmivkulkarni Feb 4, 2021
b1e4a5f
porting 7.11 unskipped management test file changes
rashmivkulkarni Feb 4, 2021
e46e977
Merge branch 'master' into backport_unskip_management_test
kibanamachine Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/functional/page_objects/settings_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ export function SettingsPageProvider({ getService, getPageObjects }: FtrProvider
async clickLinkText(text: string) {
await find.clickByDisplayedLinkText(text);
}

async clickByButtonText(text: string) {
await find.clickByButtonText(text);
}

async clickKibanaSettings() {
await testSubjects.click('settings');
await PageObjects.header.waitUntilLoadingHasFinished();
Expand Down
5 changes: 2 additions & 3 deletions x-pack/test/functional/apps/security/management.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ export default function ({ getService, getPageObjects }) {
const EDIT_ROLES_PATH = `${ROLES_PATH}/edit`;
const CLONE_ROLES_PATH = `${ROLES_PATH}/clone`;

// FLAKY: https://github.com/elastic/kibana/issues/61173
describe.skip('Management', function () {
describe('Management', function () {
this.tags(['skipFirefox']);

before(async () => {
Expand Down Expand Up @@ -150,7 +149,7 @@ export default function ({ getService, getPageObjects }) {

await PageObjects.settings.navigateTo();
await testSubjects.click('users');
await PageObjects.settings.clickLinkText('kibana_dashboard_only_user');
await PageObjects.settings.clickByButtonText('kibana_dashboard_only_user');
const currentUrl = await browser.getCurrentUrl();
expect(currentUrl).to.contain(EDIT_ROLES_PATH);
});
Expand Down