Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent jest leaking into the prod build #90318

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Feb 4, 2021

@qn895 stumbled upon the problem that when you import lens types in a plugin, x-pack/test project fails type check. It's turned out that jest types leak into the global space and conflict with mocha types declared in FTR.
Also, I suspect jest might be built into the lens distributable.

@mshustov mshustov added chore v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Feb 4, 2021
@mshustov mshustov requested a review from a team February 4, 2021 18:54
@wylieconlon wylieconlon added Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 479 478 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 877.5KB 876.8KB -637.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not run the code locally, but this appears safe. LGTM

@mshustov mshustov merged commit 81e4595 into elastic:master Feb 5, 2021
@mshustov mshustov deleted the prevent-jest-leak-lens branch February 5, 2021 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported chore Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants