Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Saved Objects] Allow exporting and importing hidden types #90178

Merged
merged 22 commits into from
Feb 14, 2021
Merged

[Saved Objects] Allow exporting and importing hidden types #90178

merged 22 commits into from
Feb 14, 2021

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Feb 3, 2021

Closes #82027

pgayvallet
pgayvallet reviewed Feb 4, 2021
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Draft review

src/core/server/core_route_handler_context.ts Outdated Show resolved Hide resolved
src/core/server/saved_objects/routes/delete.ts Outdated Show resolved Hide resolved
src/core/server/saved_objects/routes/export.ts Show resolved Hide resolved
src/core/server/saved_objects/routes/resolve_import_errors.ts Outdated Show resolved Hide resolved
x-pack/plugins/features/server/plugin.ts Outdated Show resolved Hide resolved
src/plugins/saved_objects_management/server/routes/find.ts Outdated Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

⏳ Build in-progress, with failures

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Bamieh
Copy link
Member Author

Bamieh commented Feb 8, 2021

@elasticmachine merge upstream

pgayvallet
pgayvallet reviewed Feb 9, 2021
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looking good. Just need some plugin_functional FTR tests and it will be perfect!

src/core/server/core_route_handler_context.ts Outdated Show resolved Hide resolved
src/core/server/saved_objects/routes/resolve_import_errors.ts Show resolved Hide resolved
src/plugins/saved_objects_management/server/routes/scroll_count.ts
Comment on lines +37 to +42
const includedHiddenTypes = chain(typesToInclude)
.uniq()
.filter(
(type) => typeRegistry.isHidden(type) && typeRegistry.isImportableAndExportable(type)
)
.value();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: block used at least in 3 routes, may want to factorize.

@Bamieh Bamieh marked this pull request as ready for review February 11, 2021 10:29
@Bamieh Bamieh requested a review from a team as a code owner February 11, 2021 10:29
@Bamieh Bamieh added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0 labels Feb 11, 2021
@Bamieh Bamieh requested a review from rudolf February 11, 2021 16:06
pgayvallet
pgayvallet approved these changes Feb 12, 2021
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a FTR test to ensure that exportable+hidden types are visible in the SO management UI

Apart from that, LGTM!

@Bamieh Bamieh mentioned this pull request Feb 14, 2021
Closed
14 tasks
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
savedObjectsManagement 164.1KB 164.1KB +49.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Bamieh Bamieh merged commit c1d1b2b into elastic:master Feb 14, 2021
@Bamieh Bamieh deleted the saved_objects/export_import_hidden_types branch February 14, 2021 17:05
@Bamieh Bamieh mentioned this pull request Feb 14, 2021
Merged
Bamieh added a commit that referenced this pull request Feb 15, 2021
@Bamieh @kibanamachine
[7.x] [Saved Objects] Allow exporting and importing hidden types (#90178
ccaded1 
) (#91351)

Co-authored-by: Kibana Machine <[email protected]>
@rudolf rudolf mentioned this pull request Feb 15, 2021
Closed
@Bamieh Bamieh mentioned this pull request Feb 18, 2021
Merged
@jportner jportner mentioned this pull request Jul 21, 2021
Closed
@TinaHeiligers TinaHeiligers mentioned this pull request Jul 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

@rudolf rudolf Awaiting requested review from rudolf

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SavedObjects should support importing/exporting even if they're hidden from the API
4 participants
@Bamieh @kibanamachine @rudolf @pgayvallet