[ML] Data Frame Analytics: ROC Curve Chart #89991

walterra · 2021-02-02T10:45:30Z

Summary

Part of #90421.

Adds the ROC curve chart to the results page for classification jobs in the evaluate section.

Review hints:

SCSS/Kibana UI Team: Only a SCSS file and one CSS class was renamed. For better aligning the confusion matrix and ROC curve chart a percentage based width was changed to a fixed width.
The large diff related to the Scatterplot Matrix component was caused by a rename again.
The scatterplot matrix and ROC curve chart now share an underlying VegaChart component that takes care of lazy loading.
Loading data for the evaluate panel was split up into custom hooks.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

… support.

elasticmachine · 2021-02-05T12:05:41Z

Pinging @elastic/ml-ui (:ml)

x-pack/plugins/ml/public/application/data_frame_analytics/common/analytics.ts

...ytics_exploration/components/classification_exploration/get_auc_roc_chart_vega_lite_spec.tsx

peteharverson · 2021-02-05T15:43:45Z

Anything we can do to improve the behavior here, when trying to query for class. Could also add a padding around the callout.

Would it make more sense not to use the query at all?

…e given.

walterra · 2021-02-09T11:54:09Z

@peteharverson Improved the error handling:

All error will now be displayed within one error callout.
The header of the ROC Curve Chart will always be present so the context of the error messages is more clear.
The "other" column will now be ignored and not cause an error.

peteharverson

Tested latest edits and LGTM.

qn895 · 2021-02-09T16:06:43Z

LGTM

…ices from specific scatterplot service to more generic CanvasElement service.

walterra · 2021-02-09T16:19:46Z

@pheyos Updated functional tests to assert new RocCurveChart. Refactored services from specific scatterplot service to a more generic CanvasElement service that's now used for both ScatterplotMatrix and RocCurveChart.

pheyos

Already discussed on slack, but repeating here for visibility:
I've noticed that the confusion matrix is now smaller than it used to be.
Before this PR, I could e.g. view the full matrix for the iris job:

But now the width seems to be aligned to the ROC curve, so I have to scroll around even in this small matrix to view all values:

pheyos

Functional tests LGTM, great to have them in as part of this PR 🎉

walterra · 2021-02-10T12:44:12Z

Investigating what's wrong with the bundle size increase with +7.4MB. A local analysis with webpack-bundle-analyzer shows only a few KB difference between master (6.93MB) and this PR (6.94MB).

walterra · 2021-02-10T13:35:28Z

@pheyos Fixed confusion matrix width in 98cfdb6.

walterra · 2021-02-15T11:25:05Z

@pheyos the issue with the scrollbars appearing for the confusion matrix should be fixed again:

kibanamachine · 2021-02-15T13:45:03Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ef23a14

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`ml`	1735	1742	+7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`ml`	6.3MB	6.4MB	+7.0KB

History

💔 Build #106550 failed d372518
💔 Build #106546 failed 7caf108
💚 Build #105568 succeeded aa59327
💚 Build #105271 succeeded b38a8eb
💔 Build #105232 failed ef37973

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

pheyos

LGTM

Adds the ROC curve chart to the results page for classification jobs in the evaluate section.

…ndition-for-hiding-recommded-allocation * 'master' of github.com:elastic/kibana: [Discover] Fix toggling multi fields from doc view table (elastic#91121) [ML] Data Frame Analytics: ROC Curve Chart (elastic#89991) skip flaky suite (elastic#86948) skip flaky suite (elastic#91191) Fix date histogram time zone for rollup index (elastic#90632) [Search Source] Fix retrieval of unmapped fields; Add field filters (elastic#89837) [Logs UI] Use useMlHref hook for ML links (elastic#90935) Fix values of `products.min_price` field in Kibana sample ecommerce data set (elastic#90428) [APM] Darker shade for Error group details labels (elastic#91349) [Lens] Adjust new copy for 7.12 (elastic#90413) [ML] Unskip test. Fix modelMemoryLimit value. (elastic#91280) [Lens] Fix empty display name issue in XY chart (elastic#91132) [Lens] Improves error messages when in Dashboard (elastic#90668) [Lens] Keyboard-selected items follow user traversal of drop zones (elastic#90546) [Lens] Improves ranking feature in Top values (elastic#90749) [ILM] Rollover min age tooltip and copy fixes (elastic#91110) # Conflicts: # x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/edit_policy.test.ts

Adds the ROC curve chart to the results page for classification jobs in the evaluate section.

walterra self-assigned this Feb 2, 2021

walterra force-pushed the ml-auc-roc branch from 5d4c6e8 to 2c3194b Compare February 4, 2021 10:22

walterra changed the title ~~[ML] Data Frame Analytics: AUC ROC Chart~~ [ML] Data Frame Analytics: ROC Curve Chart Feb 4, 2021

walterra added :ml Feature:Data Frame Analytics ML data frame analytics features release_note:enhancement v7.12.0 v8.0.0 labels Feb 4, 2021

walterra added 11 commits February 5, 2021 10:53

[ML] Initial AUC ROC chart.

7191305

[ML] Fetch data for AUC ROC chart.

a8e9ab0

[ML] Move data fetching to custom hooks.

cfea3d9

[ML] Improve error reporting.

2603d1e

[ML] Lazy loading.

0616963

[ML] Fix color legend.

2989959

[ML] Fix license header.

3570962

[ML] Refactor to share a common VegaChart component with lazy loading…

452530b

… support.

[ML] Tweak types. Cleanup. Translations. Chart Tweaks.

6a5ecd6

[ML] Fix types.

15092f0

[ML] Fix types.

4f505d1

walterra force-pushed the ml-auc-roc branch from ca0e56a to 4f505d1 Compare February 5, 2021 10:06

walterra marked this pull request as ready for review February 5, 2021 12:05

walterra requested review from a team as code owners February 5, 2021 12:05

walterra requested a review from peteharverson February 5, 2021 12:06

walterra mentioned this pull request Feb 5, 2021

[ML] Data Frame Analytics: ROC Curve Chart #90421

Open

7 tasks

walterra requested a review from qn895 February 5, 2021 12:19

peteharverson reviewed Feb 5, 2021

View reviewed changes

x-pack/plugins/ml/public/application/data_frame_analytics/common/analytics.ts Show resolved Hide resolved

peteharverson reviewed Feb 5, 2021

View reviewed changes

...ytics_exploration/components/classification_exploration/get_auc_roc_chart_vega_lite_spec.tsx Outdated Show resolved Hide resolved

walterra added 2 commits February 9, 2021 11:54

[ML] Improve error handling.

826044a

[ML] Avoid unnecessary fetch when no fields for scatterplot matrix ar…

18f976c

…e given.

peteharverson approved these changes Feb 9, 2021

View reviewed changes

qn895 approved these changes Feb 9, 2021

View reviewed changes

[ML] Update functional tests to assert RocCurveChart. Refactored serv…

ef37973

…ices from specific scatterplot service to more generic CanvasElement service.

walterra requested a review from pheyos February 9, 2021 16:18

[ML] Fix updated service API.

b38a8eb

pheyos reviewed Feb 10, 2021

View reviewed changes

walterra added 2 commits February 10, 2021 14:19

[ML] Fix SCSS variable used in calc().

98cfdb6

Merge branch 'master' into ml-auc-roc

aa59327

walterra added 3 commits February 15, 2021 11:21

Merge branch 'master' into ml-auc-roc

128456c

[ML] Fix imports for lazy loadable VegaChart component.

7caf108

[ML] Fix imports.

d372518

[ML] Fix import.

ef23a14

pheyos approved these changes Feb 15, 2021

View reviewed changes

walterra merged commit 2f845dd into elastic:master Feb 15, 2021

walterra deleted the ml-auc-roc branch February 15, 2021 13:49

walterra added a commit to walterra/kibana that referenced this pull request Feb 15, 2021

[ML] Data Frame Analytics: ROC Curve Chart (elastic#89991)

8f3c53c

Adds the ROC curve chart to the results page for classification jobs in the evaluate section.

walterra mentioned this pull request Feb 15, 2021

[7.x] [ML] Data Frame Analytics: ROC Curve Chart (#89991) #91405

Merged

walterra added a commit that referenced this pull request Feb 15, 2021

[ML] Data Frame Analytics: ROC Curve Chart (#89991) (#91405)

b5413d6

Adds the ROC curve chart to the results page for classification jobs in the evaluate section.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Data Frame Analytics: ROC Curve Chart #89991

[ML] Data Frame Analytics: ROC Curve Chart #89991

walterra commented Feb 2, 2021 •

edited

Loading

elasticmachine commented Feb 5, 2021

peteharverson commented Feb 5, 2021 •

edited

Loading

walterra commented Feb 9, 2021

peteharverson left a comment

qn895 commented Feb 9, 2021

walterra commented Feb 9, 2021

pheyos left a comment

pheyos left a comment

walterra commented Feb 10, 2021

walterra commented Feb 10, 2021

walterra commented Feb 15, 2021

kibanamachine commented Feb 15, 2021

pheyos left a comment

[ML] Data Frame Analytics: ROC Curve Chart #89991

[ML] Data Frame Analytics: ROC Curve Chart #89991

Conversation

walterra commented Feb 2, 2021 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Feb 5, 2021

peteharverson commented Feb 5, 2021 • edited Loading

walterra commented Feb 9, 2021

peteharverson left a comment

Choose a reason for hiding this comment

qn895 commented Feb 9, 2021

walterra commented Feb 9, 2021

pheyos left a comment

Choose a reason for hiding this comment

pheyos left a comment

Choose a reason for hiding this comment

walterra commented Feb 10, 2021

walterra commented Feb 10, 2021

walterra commented Feb 15, 2021

kibanamachine commented Feb 15, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

pheyos left a comment

Choose a reason for hiding this comment

walterra commented Feb 2, 2021 •

edited

Loading

peteharverson commented Feb 5, 2021 •

edited

Loading