-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ts project refs: Migrates Upgrade Assistant to a TS project #89949
Ts project refs: Migrates Upgrade Assistant to a TS project #89949
Conversation
@sebelga I ran the flaky test several times locally and it passes every time. Do you happen to know why the order here matters? stack trace:
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
@TinaHeiligers the flaky test is my fault (v2 migrations) and should be fixed if you merge in master since v2 migrations have been disabled again in master tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me, happy to merge when CI is done 👍🏻
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
…9949) (#90203) Co-authored-by: Kibana Machine <[email protected]>
Summary
Partially addresses #89321
Partial stats from running
node --max-old-space-size=4096 ./node_modules/.bin/tsc -p x-pack/tsconfig.json --extendedDiagnostics --noEmit
:Before:
Files: 14891
Lines: 1609898
After:
Files: 14783
Lines: 1597047