-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] Label the existing CSV job type as Deprecated #89794
Merged
tsullivan
merged 2 commits into
elastic:master
from
tsullivan:reporting/csv-deprecation-1
Feb 1, 2021
Merged
[Reporting] Label the existing CSV job type as Deprecated #89794
tsullivan
merged 2 commits into
elastic:master
from
tsullivan:reporting/csv-deprecation-1
Feb 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
release_note:skip
Skip the PR/issue when compiling release notes
v7.12.0
v7.13.0
v8.0.0
labels
Jan 29, 2021
tsullivan
force-pushed
the
reporting/csv-deprecation-1
branch
from
January 29, 2021 21:12
167b5aa
to
9087c80
Compare
tsullivan
force-pushed
the
reporting/csv-deprecation-1
branch
from
January 29, 2021 23:15
9087c80
to
1877ba3
Compare
@elasticmachine merge upstream |
tsullivan
added
the
(Deprecated) Feature:Reporting
Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead
label
Jan 31, 2021
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
ppisljar
approved these changes
Feb 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Feb 1, 2021
Co-authored-by: Kibana Machine <[email protected]>
tsullivan
added a commit
that referenced
this pull request
Feb 1, 2021
Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
16 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
(Deprecated) Feature:Reporting
Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead
release_note:skip
Skip the PR/issue when compiling release notes
v7.12.0
v7.13.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #81079
CSV Export is being re-written to use a smaller set of job parameter fields. This PR changes the labels of the types because the deprecated code will need to exist throughout 7.x for backwards compatibility with existing automated CSV reports in the wild.