Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Label the existing CSV job type as Deprecated #89794

Merged
merged 2 commits into from
Feb 1, 2021

Conversation

tsullivan
Copy link
Member

Summary

Part of #81079

CSV Export is being re-written to use a smaller set of job parameter fields. This PR changes the labels of the types because the deprecated code will need to exist throughout 7.x for backwards compatibility with existing automated CSV reports in the wild.

@tsullivan tsullivan added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.13.0 v8.0.0 labels Jan 29, 2021
@tsullivan tsullivan force-pushed the reporting/csv-deprecation-1 branch from 167b5aa to 9087c80 Compare January 29, 2021 21:12
@tsullivan tsullivan force-pushed the reporting/csv-deprecation-1 branch from 9087c80 to 1877ba3 Compare January 29, 2021 23:15
@tsullivan
Copy link
Member Author

@elasticmachine merge upstream

@tsullivan tsullivan requested review from ppisljar and a team January 31, 2021 17:53
@tsullivan tsullivan added the (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead label Jan 31, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
reporting 95.8KB 95.9KB +53.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@tsullivan tsullivan merged commit 8701ac8 into elastic:master Feb 1, 2021
@tsullivan tsullivan deleted the reporting/csv-deprecation-1 branch February 1, 2021 16:36
tsullivan added a commit to tsullivan/kibana that referenced this pull request Feb 1, 2021
tsullivan added a commit that referenced this pull request Feb 1, 2021
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants