unskip functional tests which are skipped.

test/functional/apps/dashboard/dashboard_listing.js

@@ -123,7 +123,7 @@ export default function ({ getService, getPageObjects }) {
         expect(onDashboardLandingPage).to.equal(false);
       });
 
-      it.skip('title match is case insensitive', async function () {
+      it('title match is case insensitive', async function () {
         await PageObjects.dashboard.gotoDashboardLandingPage();
         const currentUrl = await browser.getCurrentUrl();
         const newUrl = currentUrl + '&title=two%20words';

test/functional/apps/dashboard/embeddable_rendering.js

@@ -89,7 +89,7 @@ export default function ({ getService, getPageObjects }) {
   };
 
   // Failing: See https://github.com/elastic/kibana/issues/76245
-  describe.skip('dashboard embeddable rendering', function describeIndexTests() {
+  describe('dashboard embeddable rendering', function describeIndexTests() {
     before(async () => {
       await security.testUser.setRoles(['kibana_admin', 'animals', 'test_logstash_reader']);
       await esArchiver.load('dashboard/current/kibana');

test/functional/apps/dashboard/url_field_formatter.ts

@@ -37,7 +37,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   };
 
   // FLAKY: https://github.com/elastic/kibana/issues/79463
-  describe.skip('Changing field formatter to Url', () => {
+  describe('Changing field formatter to Url', () => {
     before(async function () {
       await esArchiver.load('dashboard/current/kibana');
       await kibanaServer.uiSettings.replace({

test/functional/apps/discover/_discover.js

@@ -208,7 +208,7 @@ export default function ({ getService, getPageObjects }) {
 
     describe('time zone switch', () => {
       // skipping this until we get an elastic-chart alternative to check the ticks value
-      it.skip('should show ticks in the correct time zone after switching', async function () {
+      it('should show ticks in the correct time zone after switching', async function () {
         await kibanaServer.uiSettings.replace({ 'dateFormat:tz': 'America/Phoenix' });
         await PageObjects.common.navigateToApp('discover');
         await PageObjects.header.awaitKibanaChrome();

test/functional/apps/discover/_doc_table.ts

@@ -59,7 +59,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
     it(`should load up to ${rowsHardLimit} rows when scrolling at the end of the table`, async function () {
       const initialRows = await PageObjects.discover.getDocTableRows();
       // click the Skip to the end of the table
-      await PageObjects.discover.skipToEndOfDocTable();
+      await PageObjects.discoverToEndOfDocTable();
       // now count the rows
       const finalRows = await PageObjects.discover.getDocTableRows();
       expect(finalRows.length).to.be.above(initialRows.length);
@@ -68,7 +68,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
 
     it('should go the end of the table when using the accessible Skip button', async function () {
       // click the Skip to the end of the table
-      await PageObjects.discover.skipToEndOfDocTable();
+      await PageObjects.discoverToEndOfDocTable();
       // now check the footer text content
       const footer = await PageObjects.discover.getDocTableFooter();
       log.debug(await footer.getVisibleText());

test/functional/apps/management/_scripted_fields.js

@@ -381,7 +381,7 @@ export default function ({ getService, getPageObjects }) {
 
       //add a test to sort boolean
       //existing bug: https://github.com/elastic/kibana/issues/75519 hence the issue is skipped.
-      it.skip('should sort scripted field value in Discover', async function () {
+      it('should sort scripted field value in Discover', async function () {
         await testSubjects.click(`docTableHeaderFieldSort_${scriptedPainlessFieldName2}`);
         // after the first click on the scripted field, it becomes secondary sort after time.
         // click on the timestamp twice to make it be the secondary sort key.
@@ -465,7 +465,7 @@ export default function ({ getService, getPageObjects }) {
 
       //add a test to sort date scripted field
       //https://github.com/elastic/kibana/issues/75711
-      it.skip('should sort scripted field value in Discover', async function () {
+      it('should sort scripted field value in Discover', async function () {
         await testSubjects.click(`docTableHeaderFieldSort_${scriptedPainlessFieldName2}`);
         // after the first click on the scripted field, it becomes secondary sort after time.
         // click on the timestamp twice to make it be the secondary sort key.

test/functional/apps/management/_scripted_fields_filter.js

@@ -18,7 +18,7 @@ export default function ({ getService, getPageObjects }) {
 
   // this functionality is no longer functional as of 7.0 but still needs cleanup
   // https://github.com/elastic/kibana/issues/74118
-  describe.skip('filter scripted fields', function describeIndexTests() {
+  describe('filter scripted fields', function describeIndexTests() {
     before(async function () {
       // delete .kibana index and then wait for Kibana to re-create it
       await browser.setWindowSize(1200, 800);

test/functional/apps/saved_objects_management/edit_saved_object.ts

@@ -56,7 +56,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
   };
 
   // Flaky: https://github.com/elastic/kibana/issues/68400
-  describe.skip('saved objects edition page', () => {
+  describe('saved objects edition page', () => {
     beforeEach(async () => {
       await esArchiver.load('saved_objects_management/edit_saved_object');
     });

test/functional/apps/visualize/_visualize_listing.js

@@ -11,7 +11,7 @@ export default function ({ getService, getPageObjects }) {
   const listingTable = getService('listingTable');
 
   // FLAKY: https://github.com/elastic/kibana/issues/40912
-  describe.skip('visualize listing page', function describeIndexTests() {
+  describe('visualize listing page', function describeIndexTests() {
     const vizName = 'Visualize Listing Test';
 
     describe('create and delete', function () {

x-pack/plugins/maps/public/classes/sources/ems_tms_source/ems_tms_source.js

@@ -101,7 +101,7 @@ export class EMSTMSSource extends AbstractTMSSource {
       return tmsService;
     }
 
-    throw new Error(getErrorInfo());
+    throw new Error(getErrorInfo(emsTileLayerId));
   }
 
   async getDisplayName() {

x-pack/test/functional/apps/dashboard/feature_controls/dashboard_security.ts

@@ -108,7 +108,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
       });
 
       // Can't figure out how to get this test to pass
-      it.skip(`create new dashboard shows addNew button`, async () => {
+      it(`create new dashboard shows addNew button`, async () => {
         await PageObjects.common.navigateToActualUrl(
           'dashboard',
           DashboardConstants.CREATE_NEW_DASHBOARD_URL,
@@ -320,7 +320,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
       });
 
       // Has this behavior changed?
-      it.skip(`create new dashboard redirects to the home page`, async () => {
+      it(`create new dashboard redirects to the home page`, async () => {
         await PageObjects.common.navigateToActualUrl(
           'dashboard',
           DashboardConstants.CREATE_NEW_DASHBOARD_URL,
@@ -438,7 +438,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
       });
 
       // Has this behavior changed?
-      it.skip(`create new dashboard redirects to the home page`, async () => {
+      it(`create new dashboard redirects to the home page`, async () => {
         await PageObjects.common.navigateToActualUrl(
           'dashboard',
           DashboardConstants.CREATE_NEW_DASHBOARD_URL,

x-pack/test/functional/apps/discover/async_scripted_fields.js

@@ -20,7 +20,7 @@ export default function ({ getService, getPageObjects }) {
   const security = getService('security');
 
   // Failing: See https://github.com/elastic/kibana/issues/78553
-  describe.skip('async search with scripted fields', function () {
+  describe('async search with scripted fields', function () {
     this.tags(['skipFirefox']);
 
     before(async function () {
@@ -42,7 +42,7 @@ export default function ({ getService, getPageObjects }) {
       await security.testUser.restoreDefaults();
     });
 
-    it.skip('query should show failed shards pop up', async function () {
+    it('query should show failed shards pop up', async function () {
       if (false) {
         /* If you had to modify the scripted fields, you could un-comment all this, run it, use es_archiver to update 'kibana_scripted_fields_on_logstash'
          */
@@ -74,7 +74,7 @@ export default function ({ getService, getPageObjects }) {
       });
     });
 
-    it.skip('query return results with valid scripted field', async function () {
+    it('query return results with valid scripted field', async function () {
       if (false) {
         /* the commented-out steps below were used to create the scripted fields in the logstash-* index pattern
         which are now saved in the esArchive.

x-pack/test/functional/apps/grok_debugger/grok_debugger.js

@@ -13,7 +13,7 @@ export default function ({ getService, getPageObjects }) {
   const PageObjects = getPageObjects(['grokDebugger']);
 
   // FLAKY: https://github.com/elastic/kibana/issues/84440
-  describe.skip('grok debugger app', function () {
+  describe('grok debugger app', function () {
     this.tags('includeFirefox');
     before(async () => {
       await esArchiver.load('empty_kibana');
@@ -51,7 +51,7 @@ export default function ({ getService, getPageObjects }) {
     });
 
     describe('syntax highlighting', () => {
-      it.skip('applies the correct CSS classes', async () => {
+      it('applies the correct CSS classes', async () => {
         const grokPattern = '\\[(?:-|%{NUMBER:bytes:int})\\]';
 
         await grokDebugger.setPatternInput(grokPattern);

x-pack/test/functional/apps/infra/feature_controls/index.ts

@@ -9,7 +9,7 @@ import { FtrProviderContext } from '../../../ftr_provider_context';
 
 export default function ({ loadTestFile }: FtrProviderContext) {
   // FLAKY: https://github.com/elastic/kibana/issues/35932
-  describe.skip('feature controls', function () {
+  describe('feature controls', function () {
     this.tags('skipFirefox');
     loadTestFile(require.resolve('./infrastructure_security'));
     loadTestFile(require.resolve('./infrastructure_spaces'));

x-pack/test/functional/apps/infra/home_page.ts

@@ -16,7 +16,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
   const pageObjects = getPageObjects(['common', 'infraHome']);
 
   // FLAKY: https://github.com/elastic/kibana/issues/75724
-  describe.skip('Home page', function () {
+  describe('Home page', function () {
     this.tags('includeFirefox');
     before(async () => {
       await esArchiver.load('empty_kibana');

x-pack/test/functional/apps/maps/feature_controls/maps_spaces.ts

@@ -14,7 +14,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
   const appsMenu = getService('appsMenu');
 
   // FLAKY: https://github.com/elastic/kibana/issues/38414
-  describe.skip('spaces feature controls', () => {
+  describe('spaces feature controls', () => {
     before(async () => {
       PageObjects.maps.setBasePath('/s/custom_space');
     });

x-pack/test/functional/apps/maps/layer_errors.js

@@ -10,8 +10,7 @@ import expect from '@kbn/expect';
 export default function ({ getPageObjects }) {
   const PageObjects = getPageObjects(['maps', 'header']);
 
-  // Failing: See https://github.com/elastic/kibana/issues/69617
-  describe.skip('layer errors', () => {
+  describe('layer errors', () => {
     before(async () => {
       await PageObjects.maps.loadSavedMap('layer with errors');
     });
@@ -66,14 +65,13 @@ export default function ({ getPageObjects }) {
       });
     });
 
-    // FLAKY: https://github.com/elastic/kibana/issues/36011
-    describe.skip('EMSFileSource with missing EMS id', () => {
+    describe('EMSFileSource with missing EMS id', () => {
       const MISSING_EMS_ID = 'idThatDoesNotExitForEMSFileSource';
       const LAYER_NAME = 'EMS_vector_shapes';
 
       it('should diplay error message in layer panel', async () => {
         const errorMsg = await PageObjects.maps.getLayerErrorText(LAYER_NAME);
-        expect(errorMsg).to.equal(`Unable to find EMS vector shapes for id: ${MISSING_EMS_ID}`);
+        expect(errorMsg).to.contain(MISSING_EMS_ID);
       });
 
       it('should allow deletion of layer', async () => {
@@ -89,9 +87,7 @@ export default function ({ getPageObjects }) {
 
       it('should diplay error message in layer panel', async () => {
         const errorMsg = await PageObjects.maps.getLayerErrorText(LAYER_NAME);
-        expect(errorMsg).to.equal(
-          `Unable to find EMS tile configuration for id: ${MISSING_EMS_ID}`
-        );
+        expect(errorMsg).to.contain(MISSING_EMS_ID);
       });
 
       it('should allow deletion of layer', async () => {

x-pack/test/functional/apps/maps/sample_data.js

@@ -12,7 +12,7 @@ export default function ({ getPageObjects, getService, updateBaselines }) {
   const screenshot = getService('screenshots');
 
   // FLAKY: https://github.com/elastic/kibana/issues/38137
-  describe.skip('maps loaded from sample data', () => {
+  describe('maps loaded from sample data', () => {
     // Sample data is shifted to be relative to current time
     // This means that a static timerange will return different documents
     // Setting the time range to a window larger than the sample data set

x-pack/test/functional/apps/monitoring/elasticsearch/index_detail.js

@@ -96,7 +96,7 @@ export default function ({ getService, getPageObjects }) {
         await tearDown();
       });
 
-      it.skip('should have an index summary with NA for deleted index', async () => {
+      it('should have an index summary with NA for deleted index', async () => {
         await indicesList.setFilter('deleted');
         await indicesList.clickRowByName('many-0001_clruksahirti');
 

x-pack/test/functional/apps/monitoring/elasticsearch/indices.js

@@ -45,7 +45,7 @@ export default function ({ getService, getPageObjects }) {
     });
 
     // Revisit once https://github.com/elastic/eui/issues/1322 is resolved
-    it.skip('should show indices table with correct rows after sorting by Search Rate Desc', async () => {
+    it('should show indices table with correct rows after sorting by Search Rate Desc', async () => {
       await indicesList.clickSearchCol();
       await indicesList.clickSearchCol();
 

x-pack/test/functional/apps/monitoring/elasticsearch/shards.js

@@ -16,7 +16,7 @@ export default function ({ getService, getPageObjects }) {
   const shards = getService('monitoringElasticsearchShards');
 
   // FLAKY: https://github.com/elastic/kibana/issues/47184
-  describe.skip('Elasticsearch shard legends', () => {
+  describe('Elasticsearch shard legends', () => {
     const { setup, tearDown } = getLifecycleMethods(getService, getPageObjects);
 
     before(async () => {

x-pack/test/functional/apps/monitoring/setup/metricbeat_migration.js

@@ -14,7 +14,7 @@ export default function ({ getService, getPageObjects }) {
   const PageObjects = getPageObjects(['common', 'console']);
 
   // FLAKY: https://github.com/elastic/kibana/issues/74327
-  describe.skip('Setup mode metricbeat migration', function () {
+  describe('Setup mode metricbeat migration', function () {
     describe('setup mode btn', () => {
       const { setup, tearDown } = getLifecycleMethods(getService, getPageObjects);
 

x-pack/test/functional/apps/monitoring/time_filter.js

@@ -29,15 +29,15 @@ export default function ({ getService, getPageObjects }) {
     });
 
     // FLAKY: https://github.com/elastic/kibana/issues/48910
-    it.skip('should send another request when clicking Refresh', async () => {
+    it('should send another request when clicking Refresh', async () => {
       await testSubjects.click('querySubmitButton');
       const isLoading = await PageObjects.header.isGlobalLoadingIndicatorVisible();
       expect(isLoading).to.be(true);
     });
 
     // TODO: [cr] I'm not sure this test is any better than the above one, we might need to rely solely on unit tests
     // for this functionality
-    it.skip('should send another request when changing the time picker', async () => {
+    it('should send another request when changing the time picker', async () => {
       await PageObjects.timePicker.setAbsoluteRange(
         'Aug 15, 2016 @ 21:00:00.000',
         'Aug 16, 2016 @ 00:00:00.000'

x-pack/test/functional/apps/spaces/spaces_selection.ts

@@ -23,7 +23,7 @@ export default function spaceSelectorFunctonalTests({
   ]);
 
   // FLAKY: https://github.com/elastic/kibana/issues/51942
-  describe.skip('Spaces', function () {
+  describe('Spaces', function () {
     this.tags('includeFirefox');
     describe('Space Selector', () => {
       before(async () => {

x-pack/test/functional/apps/uptime/ping_redirects.ts

@@ -20,7 +20,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
   const monitor = () => uptime.monitor;
 
   // FLAKY: https://github.com/elastic/kibana/issues/84992
-  describe.skip('Ping redirects', () => {
+  describe('Ping redirects', () => {
     const start = '~ 15 minutes ago';
     const end = 'now';