[ILM] Surfacing policy error state #89701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… called if component is not mounted
…o added test for various form error notifications across the collapsed phases
jloleysens
added
Feature:ILM
v8.0.0
Team:Kibana Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
|
Do we want to also include an error callout at the top of the policy? |
|
@mdefazio we could, but creating elements above where a user is inputting something introduces a jump that would be better to avoid IMO. What do you think? |
alisonelizabeth
approved these changes
Jan 29, 2021
There was a problem hiding this comment.
Nice work @jloleysens! I think this is a great UX improvement. Code LGTM. Verified locally.
One small suggestion - I'm not sure if the toast notification is still necessary (I can't recall having one for our other forms), but maybe @mdefazio can weigh in there.
| if (!isMounted.current) { | ||
| return; | ||
| } | ||
| // This is a hack, we need to wait for the next tick to let all of the async validation complete |
There was a problem hiding this comment.
Is it worth opening up an issue on the form lib side to consider improving this?
There was a problem hiding this comment.
Hey Alison, that is good point!
| }; | ||
|
|
||
| test('shows phase error indicators correctly', async () => { | ||
| // This test simulates a user configuring a policy phase by phase. The flow is the following: |
There was a problem hiding this comment.
Thanks for adding these comments 👍
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
We are considering changing the implementation of how form errors are detected, in conversation with @sebelga . |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
Implementation change summary:
|
|
Changes with the |
alisonelizabeth
approved these changes
Feb 2, 2021
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 3, 2021
* added policy top-level callout for error state * added form errors context. errors are sorted by their field path into phases * added data test subject attributes and prevent setErrors from getting called if component is not mounted * update copy * refactored errors context and optimised setting of context value. Also added test for various form error notifications across the collapsed phases * add test for non-phase specific policy validation error * Remove unused import * refactor how errors are listened to, use the new "onError" callback Co-authored-by: Kibana Machine <[email protected]>
jloleysens
added a commit
that referenced
this pull request
Feb 3, 2021
* added policy top-level callout for error state * added form errors context. errors are sorted by their field path into phases * added data test subject attributes and prevent setErrors from getting called if component is not mounted * update copy * refactored errors context and optimised setting of context value. Also added test for various form error notifications across the collapsed phases * add test for non-phase specific policy validation error * Remove unused import * refactor how errors are listened to, use the new "onError" callback Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
💔 Build Failed
Failed CI Steps
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/ml/data_frame_analytics/feature_importance·ts.machine learning data frame analytics total feature importance panel and decision path popover binary classification job should display the feature importance decision path in the data gridStandard OutStack TraceKibana Pipeline / general / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/delete_signals_migrations·ts.detection engine api security and spaces enabled deleting signals migrations rejects the request if the user does not have sufficient privilegesStandard OutStack TraceKibana Pipeline / general / X-Pack API Integration Tests.x-pack/test/api_integration/apis/management/index_management/indices·js.apis management index management indices list should list all the indices with the expected properties and data enrichersStandard OutStack Traceand 1 more failures, only showing the first 3. Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #87520
Adds top-level indications of ILM policy form error states for the collapsible phases.
How to test
Screenshots
Checklist
Delete any items that are not applicable to this PR.