[Security Solution] Narrow down indices to match case descriptions #89592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angorayc
added
Team: SecuritySolution
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
angorayc
added
the
release_note:skip
⏳ Build in-progress, with failures
Failed CI StepsTo update your PR or re-run it, just comment with: |
|
@elasticmachine merge upstream |
… into integration-defaultindex
|
@elasticmachine merge upstream |
This was referenced Feb 8, 2021
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
| docValueFields: [], | ||
| inspect: false, | ||
| wait_for_completion_timeout: '10s', |
There was a problem hiding this comment.
Just curious how we settled on the 10s timeout?
There was a problem hiding this comment.
Sometimes the request just takes longer than expected to return. I want to put the timeout long enough to wait until the result comes back so I am able to verify the result.
There was a problem hiding this comment.
I checked the test here: https://github.com/elastic/kibana/blob/master/x-pack/test/api_integration/apis/search/search.ts#L18
They use a very long timeout to avoid returning just partial data, so I do the same here.
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
XavierM
approved these changes
Feb 22, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @angorayc |
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Feb 22, 2021
…lastic#89592) * update default index to match with description * narrow down indices to match case description * run specific tests * run only security solution's tests * debug users integration test * wait_for_completion_timeout * run only security_solution * add back integration tests * avoid multiple requests * uncomment tests * unskip tests * add smaller mock data for users and uncommon_processes * put test back Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/test/api_integration/apis/security_solution/users.ts
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Feb 22, 2021
…lastic#89592) * update default index to match with description * narrow down indices to match case description * run specific tests * run only security solution's tests * debug users integration test * wait_for_completion_timeout * run only security_solution * add back integration tests * avoid multiple requests * uncomment tests * unskip tests * add smaller mock data for users and uncommon_processes * put test back Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/test/api_integration/apis/security_solution/users.ts
This was referenced Feb 22, 2021
angorayc
added a commit
that referenced
this pull request
Feb 23, 2021
…ions (#89592) (#92284) * [Security Solution] Narrow down indices to match case descriptions (#89592) * update default index to match with description * narrow down indices to match case description * run specific tests * run only security solution's tests * debug users integration test * wait_for_completion_timeout * run only security_solution * add back integration tests * avoid multiple requests * uncomment tests * unskip tests * add smaller mock data for users and uncommon_processes * put test back Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/test/api_integration/apis/security_solution/users.ts * update mocked users data * update mocked index * update mocked index * update mocked index * update mock data
angorayc
added a commit
that referenced
this pull request
Feb 23, 2021
…ons (#89592) (#92283) * [Security Solution] Narrow down indices to match case descriptions (#89592) * update default index to match with description * narrow down indices to match case description * run specific tests * run only security solution's tests * debug users integration test * wait_for_completion_timeout * run only security_solution * add back integration tests * avoid multiple requests * uncomment tests * unskip tests * add smaller mock data for users and uncommon_processes * put test back Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # x-pack/test/api_integration/apis/security_solution/users.ts * update mocked users data * update mocked index * update mocked index * update mocked index * update mock data * update mock data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to fix #87793
Before we put the defaultIndex of requests too broad, sometimes make the tests flaky.
Similar problem happens to other tests, so remove redundant index along here in this PR.
I also extend the timeout for each test to 10s to avoid returning partial data. For this
usersanduncommon_cases, I create two mock data which are smaller than the original ones they used. This should be able to reduce the query time.