[plugin cli] Wrap arguments in quotes to preserve whitespace #8945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this be done in kibana-plugin.bat as well? |
|
Windows should be good, escaping does work via wrapping in quotes. Escaping by \ isn't normally done as far as I can tell. |
|
LGTM |
elastic-jasper
added a commit
that referenced
this pull request
Nov 17, 2016
Backports PR #8945 **Commit 1:** [plugin cli] Wrap arguments in quotes to preserve whitespace * Original sha: 18d6e92 * Authored by Jonathan Budzenski <[email protected]> on 2016-11-02T17:28:49Z
elastic-jasper
added a commit
that referenced
this pull request
Nov 17, 2016
Backports PR #8945 **Commit 1:** [plugin cli] Wrap arguments in quotes to preserve whitespace * Original sha: 18d6e92 * Authored by Jonathan Budzenski <[email protected]> on 2016-11-02T17:28:49Z
This was referenced Nov 17, 2016
jbudz
pushed a commit
that referenced
this pull request
Nov 17, 2016
Backports PR #8945 **Commit 1:** [plugin cli] Wrap arguments in quotes to preserve whitespace * Original sha: 18d6e92 * Authored by Jonathan Budzenski <[email protected]> on 2016-11-02T17:28:49Z
jbudz
pushed a commit
that referenced
this pull request
Nov 17, 2016
Backports PR #8945 **Commit 1:** [plugin cli] Wrap arguments in quotes to preserve whitespace * Original sha: 18d6e92 * Authored by Jonathan Budzenski <[email protected]> on 2016-11-02T17:28:49Z
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
…#9124) Backports PR elastic#8945 **Commit 1:** [plugin cli] Wrap arguments in quotes to preserve whitespace * Original sha: 18d6e92 * Authored by Jonathan Budzenski <[email protected]> on 2016-11-02T17:28:49Z Former-commit-id: 6eb9b26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing plugins we are passing interpreted cli arguments back to node, which is causing filenames with spaces to be split up.
At the script level,
bin/kibana-plugin install file:///Users/jbudz/Downloads/temp\ dir/x-pack-5.0.0.zipturned intonode src/cli_plugin install file:///Users/jbudz/Downloads/temp dir/x-pack-5.0.0.zip. Instead, we now pass asnode src/cli_plugin "install" "file:///Users/jbudz/Downloads/temp dir/x-pack-5.0.0.zip"I left the .bat as is, wrapping quotes around "file://...." seems to be working as expected for escaping spaces.
Closes #7325