Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update central config to include Go agent #89445

Merged
merged 2 commits into from
Jan 28, 2021
Merged

update central config to include Go agent #89445

merged 2 commits into from
Jan 28, 2021

Conversation

jalvz
Copy link
Contributor

@jalvz jalvz commented Jan 27, 2021

Summary

Support added in elastic/apm-agent-go#872

@jalvz jalvz added Team:APM All issues that need APM UI Team support apm:Agent Configuration v7.12.0 labels Jan 27, 2021
@jalvz jalvz requested a review from a team as a code owner January 27, 2021 16:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@jalvz jalvz added the release_note:skip Skip the PR/issue when compiling release notes label Jan 27, 2021
smith
smith requested changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@smith smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jalvz this looks fine but you'll also have to add a line to a test that verifies these lists are correct:

kibana/x-pack/plugins/apm/common/agent_configuration/setting_definitions/index.test.ts

Lines 45 to 55 in 6b448d2

expect(getSettingKeysForAgent('go')).toEqual([
'capture_body',
'capture_headers',
'log_level',
'recording',
'sanitize_field_names',
'span_frames_min_duration',
'stack_trace_limit',
'transaction_max_spans',
'transaction_sample_rate',
]);

@sorenlouv
Copy link
Member

sorenlouv commented Jan 28, 2021 •
edited
Loading

Adding to what @smith said:

You can run the APM jest tests with the following command:

cd x-pack/plugins/apm && ../../../node_modules/.bin/jest

To only run agent config tests:

cd x-pack/plugins/apm && ../../../node_modules/.bin/jest agent_configuration

sorenlouv
sorenlouv approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When tests are passing

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.2MB 5.2MB +5.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 77f8e62 into elastic:master Jan 28, 2021
@smith
Copy link
Contributor

smith commented Jan 28, 2021

Merged and created a backport.

smith pushed a commit to smith/kibana that referenced this pull request Jan 28, 2021
@jalvz @smith
update central config to include Go agent (elastic#89445)
b266d24
@smith smith mentioned this pull request Jan 28, 2021
Merged
smith added a commit that referenced this pull request Jan 28, 2021
@smith @jalvz
update central config to include Go agent (#89445) (#89565)
23f8f7c 
Co-authored-by: Juan Álvarez <[email protected]>
@jalvz
Copy link
Contributor Author

jalvz commented Jan 29, 2021

Thanks all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smith smith smith approved these changes

@sorenlouv sorenlouv sorenlouv approved these changes

Assignees
No one assigned
Labels
apm:Agent Configuration release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jalvz @elasticmachine @sorenlouv @kibanamachine @smith