[Enterprise Search] Update apps to use a service for docs links

[scottybollinger]

Summary

Adds a local DocLinks service in Enterprise Search to facilitate using the Kibana DocLinksService.

I tried to hook into KibanaLogic with the data but both the routes files are instantiated before the logic mounts and this was the only way I could get the values into our apps at the start of the app lifecycle. Open to suggestions if there is a better way.

Best to follow along by commit.

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

[goodroot]

FYI @chriscressman -- this is a thing.

[scottybollinger]

@elasticmachine merge upstream

[yakhinvadim]

This is great, thanks, Scotty!

[scottybollinger]

Thanks @constancecchen. That was my first thought as well and I tried that. Unfortunately, the routes.ts files are instantiated before docLinksService.setDocLinks is called and the values are empty strings that are set in the constructor

[scottybollinger]

Here's a better view:

[cee-chen]

My diff/commit is currently working as-is locally for me without issue. Want to hop on a screen share?

[cee-chen]

Actually, that's super strange. It's working on http://localhost:5601/xlc/app/enterprise_search/overview/setup_guide (and all other setup guides), but it looks like you're correct that it's not working for that specific Workplace Search documentation link. Odd, looking into this now

EDIT: It's also working for http://localhost:5601/xlc/app/enterprise_search/app_search/settings/account (app search docs link). I suspect something is wrong with that specific Workplace Search doc link

[cee-chen]

After some debugging w/ Scotty I've figured out that this is a very weird race condition, and sometimes does and doesn't work. e.g. App Search links were working for me initially but after some hard refreshes stopped working. So we can't rely on moving initialization to index.tsx if using this approach (static strings in routes.tsx). I'll collapse my previous comment in that case as a wontfix

[cee-chen]

🙇‍♀️ Thanks so much for doing this work Scotty!!

[cee-chen]

[not a blocker, just leaving this comment here before I forget it] It would be awesome to directly add cloudBase into the Kibana core helper someday! I'm sure other plugins might need it at some point

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 1cb8342

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
enterpriseSearch	1171	1165	-6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
enterpriseSearch	1.8MB	1.8MB	-34.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
enterpriseSearch	14.4KB	15.4KB	+1.0KB

History

• 💚 Build #101765 succeeded be4d776
• 💚 Build #101452 succeeded 7c05410

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[chriscressman]

This is great. Thanks for moving us over to the docs links service so quickly Scotty!