-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] Implement searchSessionId in MapEmbeddable #89342
Conversation
Pinging @elastic/kibana-gis (Team:Geo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the following scenarios using [Flights] Global Flight Dashboard
and all LGTM:
searchSessionId
appears in the inspector. It properly changes on dashboard state changes- Restoring a session with maps works
- When using an incorrect
searchSessionId
maps requests fail, which is correct.
We have some functional test coverage for search session in a dashboard. For example, if we could add an assertion here that maps embeddable is loaded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx for adding, really cool
@elasticmachine merge upstream |
⏳ Build in-progress, with failures
Failed CI StepsHistory
To update your PR or re-run it, just comment with: |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
* [Maps] Implement searchSessionId in MapEmbeddable * clean up * update method name * fix _unsubscribeFromStore subscription * fix unit test * add maps assertion to send_to_background_relative_time functional test * fix functional assertion Co-authored-by: Kibana Machine <[email protected]>
* [Maps] Implement searchSessionId in MapEmbeddable * clean up * update method name * fix _unsubscribeFromStore subscription * fix unit test * add maps assertion to send_to_background_relative_time functional test * fix functional assertion Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Fixes #85449
This PR updates MapEmbeddable to pass searchSessionId to setQuery redux action. The PR then updates all calls to searchSource.fetch to pass sessionId into call. With these updates, MapEmbeddable panels will work with searchSessionIds.
To test, add
xpack.data_enhanced.search.sessions.enabled: true
to kibana.dev.yml. Then add a MapEmbeddable to dashboard. Open the inspector for the panel and notice that there is a sessionId for each _search request.