TypeScript project references for Observability plugin #89320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
References elastic#80508. References elastic#81003.
smith
added
v8.0.0
release_note:skip
|
@elasticmachine merge upstream |
dgieselaar
reviewed
Feb 2, 2021
| @@ -4,10 +4,10 @@ | |||
| * you may not use this file except in compliance with the Elastic License. | |||
| */ | |||
|
|
|||
| import { PromiseValueType } from '../../../apm/typings/common'; | |||
| import type { UnwrapPromise } from '@kbn/utility-types'; | |||
dgieselaar
reviewed
Feb 2, 2021
x-pack/tsconfig.refs.json
Outdated
| @@ -1,8 +1,8 @@ | |||
| { | |||
| "include": [], | |||
| "references": [ | |||
| { "path": "./plugins/actions/tsconfig.json"}, | |||
| { "path": "./plugins/alerts/tsconfig.json"}, | |||
| { "path": "./plugins/actions/tsconfig.json" }, | |||
There was a problem hiding this comment.
Do these files have more changes than necessary?
There was a problem hiding this comment.
There were duplicates, which weren't breaking anything but weren't necessary.
dgieselaar
approved these changes
Feb 2, 2021
smith
commented
Feb 2, 2021
| @@ -25,6 +25,7 @@ | |||
| "plugins/maps/**/*", | |||
There was a problem hiding this comment.
This has been alphabetized and some duplicates have been removed.
smith
commented
Feb 2, 2021
| @@ -20,36 +20,27 @@ | |||
| { "path": "./plugins/global_search_providers/tsconfig.json" }, | |||
There was a problem hiding this comment.
This has been alphabetized and some duplicates have been removed.
15 tasks
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
smith
added a commit
to smith/kibana
that referenced
this pull request
Feb 2, 2021
References elastic#80508. References elastic#81003. # Conflicts: # x-pack/tsconfig.refs.json
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Feb 2, 2021
…-ml-jobs * 'master' of github.com:elastic/kibana: (254 commits) [Security Solution] [Detections] Remove allow_no_indices to prevent error being thrown in response of field capabilities (elastic#89927) Skip test for cloud (elastic#89450) [Fleet] Fix duplicate data streams being shown in UI (elastic#89812) Bump package dependencies (elastic#90034) [App Search] DRY helper for encoding/decoding routes that can have special characters in params (elastic#89811) TypeScript project references for Observability plugin (elastic#89320) [SearchSource] Combine sort and parent fields when serializing (elastic#89808) Made imports static (elastic#89935) [ml] migrate file_data_visualizer/import route to file_upload plugin (elastic#89640) [Discover] Adapt default column behavior (elastic#89826) Round start and end values (elastic#89030) Rename getProxyAgents to getCustomAgents (elastic#89813) [Form lib] UseField `onError` listener (elastic#89895) [APM] use latency sum instead of avg for impact (elastic#89990) migrate more core-owned plugins to tsproject ref (elastic#89975) [Logs UI] Load <LogStream> entries via async searches (elastic#86899) [APM] Abort browser requests when appropriate (elastic#89557) [Alerting] Allow user to select existing connector of same type when fixing broken connector (elastic#89062) [Data Table] Use shared CSV export mechanism (elastic#89702) chore(NA): improve logic check when installing Bazel tools (elastic#89634) ...
smith
added a commit
that referenced
this pull request
Feb 2, 2021
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #80508. References #81003.
Also alphabetize tsconfigs where the plugin reference was added.