[5.x] Current styleguide conventions with modern JS #8929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backports PR #7435 **Commit 1:** Current styleguide conventions with modern JS The existing styleguide was in great need of a rewrite as it did not reflect the conventions we're using in the codebase or even the best practices that we follow. In some cases, the guidance it provided was outright contrary to our current practices. * Original sha: 13e501b * Authored by Court Ewing <[email protected]> on 2016-06-12T14:03:13Z
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Backports PR elastic#7435 **Commit 1:** Current styleguide conventions with modern JS The existing styleguide was in great need of a rewrite as it did not reflect the conventions we're using in the codebase or even the best practices that we follow. In some cases, the guidance it provided was outright contrary to our current practices. * Original sha: 13e501b * Authored by Court Ewing <[email protected]> on 2016-06-12T14:03:13Z Former-commit-id: e967153
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Apr 16, 2024
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Apr 18, 2024
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Apr 18, 2024
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Apr 23, 2024
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Apr 24, 2024
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Apr 25, 2024
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Apr 26, 2024
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current styleguide conventions with modern JS
Backports PR #7435
Commit 1:
Current styleguide conventions with modern JS
The existing styleguide was in great need of a rewrite as it did not
reflect the conventions we're using in the codebase or even the best
practices that we follow. In some cases, the guidance it provided was
outright contrary to our current practices.