Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [alerts] adds support for index threshold index param string type (#88540) #89236

Merged
merged 2 commits into from
Jan 26, 2021

Conversation

pmuellr
Copy link
Member

@pmuellr pmuellr commented Jan 25, 2021

Backports the following commits to 7.x:

…astic#88540)

resolves elastic#68575

The index threshold alert defines an `index` parameter which is
typed as `string | string[]`.  However the UI for this alert has
been typing it as only `string[]`.

This PR changes the UI to work with an incoming string value for
this parameter.  If the parameter is edited in the UI, it will always
be set as an array, even if there is only one element.
@pmuellr
Copy link
Member Author

pmuellr commented Jan 25, 2021

hmmm, more rando flaky tests in the backport? Had some in the originating PR as well ...

"Jest Integration Tests" failures
Summary of all failing tests
 FAIL  src/core/server/ui_settings/create_or_upgrade_saved_config/integration_tests/create_or_upgrade.test.ts (282.005 s)
  ● createOrUpgradeSavedConfig() › upgrades the previous version on each increment

    Timeout - Async callback was not invoked within the 280000 ms timeout specified by jest.setTimeout.Error: Timeout - Async callback was not invoked within the 280000 ms timeout specified by jest.setTimeout.

      at mapper (../../../kibana/node_modules/jest-jasmine2/build/queueRunner.js:27:45)

  ● createOrUpgradeSavedConfig() › upgrades the previous version on each increment

    TypeError: Cannot read property 'find' of undefined

      25 | }) {
      26 |   // attempt to find a config we can upgrade
    > 27 |   const { saved_objects: savedConfigs } = await savedObjectsClient.find({
         |                                                                    ^
      28 |     type: 'config',
      29 |     page: 1,
      30 |     perPage: 1000,

      at getUpgradeableConfig (src/core/server/ui_settings/create_or_upgrade_saved_config/get_upgradeable_config.ts:27:68)
      at createOrUpgradeSavedConfig (src/core/server/ui_settings/create_or_upgrade_saved_config/create_or_upgrade_saved_config.ts:31:35)
      at Object.<anonymous> (src/core/server/ui_settings/create_or_upgrade_saved_config/integration_tests/create_or_upgrade.test.ts:77:11)

kicking off a merge upstream ...

@pmuellr
Copy link
Member Author

pmuellr commented Jan 25, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackAlerts 114.6KB 114.8KB +139.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pmuellr pmuellr merged commit 9177551 into elastic:7.x Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants