Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Monitoring] Add toast for newly created alerts #89202

Merged
merged 2 commits into from
Jan 26, 2021
Merged

[Monitoring] Add toast for newly created alerts #89202

merged 2 commits into from
Jan 26, 2021

Conversation

chrisronline
Copy link
Contributor

Relates to #81020

This adds a toast letting the user know new alerts exist and they may need to configure actions for them. See #81020 (comment)

@chrisronline chrisronline added review Team:Monitoring Stack Monitoring team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Jan 25, 2021
@chrisronline chrisronline requested a review from a team January 25, 2021 18:44
@chrisronline chrisronline self-assigned this Jan 25, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@chrisronline chrisronline mentioned this pull request Jan 25, 2021
Closed
3 tasks
@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

igoristic
igoristic approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

nit: I think we should also include an external link in the message to: https://www.elastic.co/guide/en/kibana/current/kibana-alerts.html

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 982.7KB 983.5KB +802.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit da72cd4 into elastic:master Jan 26, 2021
@chrisronline chrisronline deleted the monitoring/add_alerts_toast branch January 26, 2021 02:11
chrisronline added a commit to chrisronline/kibana that referenced this pull request Jan 26, 2021
@chrisronline @kibanamachine
Add toast for newly created alerts (elastic#89202)
c31eb91 
Co-authored-by: Kibana Machine <[email protected]>
@chrisronline chrisronline mentioned this pull request Jan 26, 2021
Merged
chrisronline added a commit that referenced this pull request Jan 26, 2021
@chrisronline @kibanamachine
Add toast for newly created alerts (#89202) (#89258)
3fc8860 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@chrisronline chrisronline mentioned this pull request Mar 1, 2021
Closed
24 tasks
@simianhacker simianhacker mentioned this pull request Apr 29, 2021
Closed
24 tasks
@neptunian neptunian mentioned this pull request Jul 6, 2021
Closed
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igoristic igoristic igoristic approved these changes

Assignees

@chrisronline chrisronline

Labels
release_note:skip Skip the PR/issue when compiling release notes review Team:Monitoring Stack Monitoring team v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisronline @elasticmachine @kibanamachine @igoristic