Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kui-prefixed form and page components. #8910

Merged
merged 1 commit into from
Dec 8, 2016

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Nov 1, 2016

These new components will be moved to the UI Framework in a subsequent PR.

New components

  • Third party overrides.
  • kuiList
  • kuiListItem
  • kuiPage
  • kuiPageView
  • kuiSubHeader
  • kuiNotice
  • kuiNoticeTitle
  • kuiNoticeText
  • kuiCard
  • kuiCardGroup
  • kuiButton
  • kuiIcon
  • kuiTitle
  • kuiBadge
  • kuiFormSection
  • kuiFormSubSection
  • kuiColumn
  • kuiFormLabel
  • kuiFormSubLabel
  • kuiTextArea
  • kuiInput
  • kuiStaticInput
  • kuiOptionLabel
  • kuiCheckbox
  • kuiFormPanel
  • kuiFormPanelLayout
  • kuiMenuItem
  • kuiInputNote
  • kuiTableControls
  • kuiTableControlAction
  • fullWidth
  • noPadding

@cjcenizal cjcenizal force-pushed the improvement/components branch 2 times, most recently from 0ba244a to fec8a27 Compare November 1, 2016 01:05
@cjcenizal cjcenizal changed the title [WIP] Add kui-prefixed form and page components. Add kui-prefixed form and page components. Nov 1, 2016
@lukasolson lukasolson self-assigned this Nov 1, 2016
@thomasneirynck thomasneirynck self-assigned this Nov 1, 2016
@thomasneirynck
Copy link
Contributor

thomasneirynck commented Nov 1, 2016

No particular comments above what's been discussed already in the corresponding X-plugins PR. I'm a fan of the prefixing, great for legibility.

LGTM

Copy link
Member

@lukasolson lukasolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjcenizal cjcenizal force-pushed the improvement/components branch from fec8a27 to ba06ed3 Compare November 3, 2016 23:52
@lukasolson lukasolson removed their assignment Nov 4, 2016
@cjcenizal cjcenizal force-pushed the improvement/components branch from ba06ed3 to 162a2f0 Compare November 19, 2016 00:56
@cjcenizal
Copy link
Contributor Author

jenkins, test this

@cjcenizal cjcenizal added v5.1.0 and removed v5.1.0 labels Nov 21, 2016
@cjcenizal cjcenizal force-pushed the improvement/components branch 2 times, most recently from 910329d to f15dc0a Compare November 22, 2016 16:56
@cjcenizal cjcenizal added v5.2.0 and removed v5.1.0 labels Nov 22, 2016
- Third party overrides.
- kuiList
- kuiListItem
- kuiPage
- kuiPageView
- kuiSubHeader
- kuiNotice
- kuiNoticeTitle
- kuiNoticeText
- kuiCard
- kuiCardGroup
- kuiButton
- kuiIcon
- kuiTitle
- kuiBadge
- kuiFormSection
- kuiFormSubSection
- kuiColumn
- kuiFormLabel
- kuiFormSubLabel
- kuiTextArea
- kuiInput
- kuiStaticInput
- kuiOptionLabel
- kuiCheckbox
- kuiFormPanel
- kuiFormPanelLayout
- kuiMenuItem
- kuiInputNote
- kuiTableControls
- kuiTableControlAction
- fullWidth
- noPadding
@cjcenizal cjcenizal force-pushed the improvement/components branch from f15dc0a to 39b0146 Compare December 8, 2016 19:28
@cjcenizal cjcenizal merged commit 2860b12 into elastic:master Dec 8, 2016
@cjcenizal cjcenizal deleted the improvement/components branch December 8, 2016 21:55
elastic-jasper added a commit that referenced this pull request Dec 13, 2016
Backports PR #8910

**Commit 1:**
Add form and page components.
- Third party overrides.
- kuiList
- kuiListItem
- kuiPage
- kuiPageView
- kuiSubHeader
- kuiNotice
- kuiNoticeTitle
- kuiNoticeText
- kuiCard
- kuiCardGroup
- kuiButton
- kuiIcon
- kuiTitle
- kuiBadge
- kuiFormSection
- kuiFormSubSection
- kuiColumn
- kuiFormLabel
- kuiFormSubLabel
- kuiTextArea
- kuiInput
- kuiStaticInput
- kuiOptionLabel
- kuiCheckbox
- kuiFormPanel
- kuiFormPanelLayout
- kuiMenuItem
- kuiInputNote
- kuiTableControls
- kuiTableControlAction
- fullWidth
- noPadding

* Original sha: 39b0146
* Authored by CJ Cenizal <[email protected]> on 2016-10-24T18:09:53Z
cjcenizal pushed a commit that referenced this pull request Dec 13, 2016
Backports PR #8910

**Commit 1:**
Add form and page components.
- Third party overrides.
- kuiList
- kuiListItem
- kuiPage
- kuiPageView
- kuiSubHeader
- kuiNotice
- kuiNoticeTitle
- kuiNoticeText
- kuiCard
- kuiCardGroup
- kuiButton
- kuiIcon
- kuiTitle
- kuiBadge
- kuiFormSection
- kuiFormSubSection
- kuiColumn
- kuiFormLabel
- kuiFormSubLabel
- kuiTextArea
- kuiInput
- kuiStaticInput
- kuiOptionLabel
- kuiCheckbox
- kuiFormPanel
- kuiFormPanelLayout
- kuiMenuItem
- kuiInputNote
- kuiTableControls
- kuiTableControlAction
- fullWidth
- noPadding

* Original sha: 39b0146
* Authored by CJ Cenizal <[email protected]> on 2016-10-24T18:09:53Z
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants