-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kui-prefixed form and page components. #8910
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
force-pushed
the
improvement/components
branch
2 times, most recently
from
November 1, 2016 01:05
0ba244a
to
fec8a27
Compare
cjcenizal
changed the title
[WIP] Add kui-prefixed form and page components.
Add kui-prefixed form and page components.
Nov 1, 2016
No particular comments above what's been discussed already in the corresponding X-plugins PR. I'm a fan of the prefixing, great for legibility. LGTM |
lukasolson
approved these changes
Nov 1, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cjcenizal
force-pushed
the
improvement/components
branch
from
November 3, 2016 23:52
fec8a27
to
ba06ed3
Compare
cjcenizal
force-pushed
the
improvement/components
branch
from
November 19, 2016 00:56
ba06ed3
to
162a2f0
Compare
jenkins, test this |
cjcenizal
force-pushed
the
improvement/components
branch
2 times, most recently
from
November 22, 2016 16:56
910329d
to
f15dc0a
Compare
- Third party overrides. - kuiList - kuiListItem - kuiPage - kuiPageView - kuiSubHeader - kuiNotice - kuiNoticeTitle - kuiNoticeText - kuiCard - kuiCardGroup - kuiButton - kuiIcon - kuiTitle - kuiBadge - kuiFormSection - kuiFormSubSection - kuiColumn - kuiFormLabel - kuiFormSubLabel - kuiTextArea - kuiInput - kuiStaticInput - kuiOptionLabel - kuiCheckbox - kuiFormPanel - kuiFormPanelLayout - kuiMenuItem - kuiInputNote - kuiTableControls - kuiTableControlAction - fullWidth - noPadding
cjcenizal
force-pushed
the
improvement/components
branch
from
December 8, 2016 19:28
f15dc0a
to
39b0146
Compare
elastic-jasper
added a commit
that referenced
this pull request
Dec 13, 2016
Backports PR #8910 **Commit 1:** Add form and page components. - Third party overrides. - kuiList - kuiListItem - kuiPage - kuiPageView - kuiSubHeader - kuiNotice - kuiNoticeTitle - kuiNoticeText - kuiCard - kuiCardGroup - kuiButton - kuiIcon - kuiTitle - kuiBadge - kuiFormSection - kuiFormSubSection - kuiColumn - kuiFormLabel - kuiFormSubLabel - kuiTextArea - kuiInput - kuiStaticInput - kuiOptionLabel - kuiCheckbox - kuiFormPanel - kuiFormPanelLayout - kuiMenuItem - kuiInputNote - kuiTableControls - kuiTableControlAction - fullWidth - noPadding * Original sha: 39b0146 * Authored by CJ Cenizal <[email protected]> on 2016-10-24T18:09:53Z
cjcenizal
pushed a commit
that referenced
this pull request
Dec 13, 2016
Backports PR #8910 **Commit 1:** Add form and page components. - Third party overrides. - kuiList - kuiListItem - kuiPage - kuiPageView - kuiSubHeader - kuiNotice - kuiNoticeTitle - kuiNoticeText - kuiCard - kuiCardGroup - kuiButton - kuiIcon - kuiTitle - kuiBadge - kuiFormSection - kuiFormSubSection - kuiColumn - kuiFormLabel - kuiFormSubLabel - kuiTextArea - kuiInput - kuiStaticInput - kuiOptionLabel - kuiCheckbox - kuiFormPanel - kuiFormPanelLayout - kuiMenuItem - kuiInputNote - kuiTableControls - kuiTableControlAction - fullWidth - noPadding * Original sha: 39b0146 * Authored by CJ Cenizal <[email protected]> on 2016-10-24T18:09:53Z
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These new components will be moved to the UI Framework in a subsequent PR.
New components