[Monitoring] Fix newly added cloud link #89067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
added
review
Team:Monitoring
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
|
@elasticmachine merge upstream |
igoristic
approved these changes
Jan 25, 2021
| @@ -32,7 +32,7 @@ export const CloudDeployment = () => { | |||
| defaultMessage="section for a deployment to configure monitoring. For more information visit " | |||
| /> | |||
| <EuiLink | |||
| href="https://www.elastic.co/guide/en/cloud/current/ec-enable-monitoring.html" | |||
| href="https://www.elastic.co/guide/en/cloud/current/ec-enable-logging-and-monitoring.html" | |||
There was a problem hiding this comment.
I think we should use our global statics here to maintain consistency, eg:
Suggested change
| href="https://www.elastic.co/guide/en/cloud/current/ec-enable-logging-and-monitoring.html" | |
| href=`${docLinks.ELASTIC_WEBSITE_URL}guide/en/cloud/${docLinks.DOC_LINK_VERSION}/ec-enable-logging-and-monitoring.html` |
There was a problem hiding this comment.
Love it! I'll update
There was a problem hiding this comment.
I can't seem to use DOC_LINK_VERSION as it resolves to master instead of current which breaks the URL
There was a problem hiding this comment.
It will resolve to current (or the build version) once it's built, but you can do something like this to override master:
const version = (docLinks.DOC_LINK_VERSION === 'master') ? 'current' : docLinks.DOC_LINK_VERSION;
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
This was referenced Jan 26, 2021
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Jan 26, 2021
* Fix cloud link * Update link * Fix tests Co-authored-by: Kibana Machine <[email protected]>
chrisronline
added a commit
that referenced
this pull request
Jan 26, 2021
* Fix cloud link * Update link * Fix tests Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
chrisronline
added a commit
that referenced
this pull request
Jan 26, 2021
* Fix cloud link * Update link * Fix tests Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #88951