Use doc link service in more Stack Monitoring pages #89050
Conversation
lcawl
force-pushed
the
monitor-doc-links2
branch
from
5be048a to
bacc288
Compare
lcawl
force-pushed
the
monitor-doc-links2
branch
from
457a393 to
58292d7
Compare
|
@elasticmachine merge upstream |
lcawl
added
release_note:skip
| @@ -193,8 +198,11 @@ export class DocLinksService { | |||
| alertsKibanaDiskThreshold: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/kibana-alerts.html#kibana-alerts-disk-usage-threshold`, | |||
| alertsKibanaJvmThreshold: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/kibana-alerts.html#kibana-alerts-jvm-memory-threshold`, | |||
| alertsKibanaMissingData: `${ELASTIC_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/kibana-alerts.html#kibana-alerts-missing-monitoring-data`, | |||
| metricbeatBlog: `${ELASTIC_WEBSITE_URL}blog/external-collection-for-elastic-stack-monitoring-is-now-available-via-metricbeat`, | |||
There was a problem hiding this comment.
nit: As this URL doesn't rely on ${DOC_LINK_VERSION}, and there might be more metricbeat blog links in the future, it might make more sense to keep the prior implementation where the consuming code is just using ELASTIC_WEBSITE_URL directly with the blog path. Or alternatively to export a ELASTIC_WEBSITE_BLOG_URL to be used with a corresponding path. But no strong feelings on that.
There was a problem hiding this comment.
So far I haven't found a lot of blog links, so I think this announcement was exceptional. If more of them get added in the future, I agree that we should consider having a different base url that all of them can share (though I'd still vote for having keywords in the shared file rather than having the blog URLs sprinkled across the code.. we don't test those so it's easy to lose track of them).
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Co-authored-by: igoristic <[email protected]>
* master: (244 commits) [maps] Top hits per entity--change to title to use recent, minor edits (elastic#89254) [DOCS] Update installation details (elastic#90354) RFC for automatically generated typescript API documentation for every plugins public services, types, and functionality (elastic#86704) Elastic Maps Server config is `host` not `hostname` (elastic#90234) Use doc link services in index pattern management (elastic#89937) [Fleet] Managed Agent Policy (elastic#88688) [Workplace Search] Fix Source Settings bug (elastic#90242) [Enterprise Search] Refactor MockRouter test helper to not store payload (elastic#90206) Use doc link service in more Stack Monitoring pages (elastic#89050) [App Search] Relevance Tuning logic - actions and selectors only, no listeners (elastic#89313) Remove UI filters from UI (elastic#89793) Use newfeed.service config for all newsfeeds (elastic#90252) skip flaky suite (elastic#85086) Add readme to geo containment alert covering test alert setup (elastic#89625) [APM] Enabling yesterday option when 24 hours is selected (elastic#90017) Test user for maps tests under import geoJSON tests (elastic#86015) [Lens] Hide column in table (elastic#88680) [Security Solution][Detections] Reduce detection engine reliance on _source (elastic#89371) [Discover] Minor cleanup (elastic#90260) [Search Session][Management] Rename "cancel" button and delete "Reload" button (elastic#90015) ...
Co-authored-by: igoristic <[email protected]>
Summary
Related to #88107 and #88920
This PR uses doc link service keywords instead of hard-coded URLs in Stack Monitoring, so that they're easier to maintain.