-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Warning When Leaving from Visualize Listing Page #89041
Merged
ThomThomson
merged 2 commits into
elastic:master
from
ThomThomson:fix/visualizeWarningFromlistingPage
Jan 25, 2021
Merged
Fix Warning When Leaving from Visualize Listing Page #89041
ThomThomson
merged 2 commits into
elastic:master
from
ThomThomson:fix/visualizeWarningFromlistingPage
Jan 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from listing page
ThomThomson
added
Feature:Vis Editor
Visualization editor issues
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.11.0
v7.12.0
labels
Jan 21, 2021
@elasticmachine merge upstream |
stratoula
approved these changes
Jan 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested it locally, bug is fixed
💛 Build succeeded, but was flaky
Test FailuresX-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/rbac_legacy·ts.alerting api integration security and spaces enabled Alerts legacy alerts alerts "before all" hook in "alerts"Standard Out
Stack Trace
X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/rbac_legacy·ts.alerting api integration security and spaces enabled Alerts legacy alerts alerts "after all" hook in "alerts"Standard Out
Stack Trace
X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/index·ts.alerting api integration security and spaces enabled Alerts legacy alerts "after all" hook in "legacy alerts"Standard Out
Stack Trace
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Jan 25, 2021
… from listing page (elastic#89041)
ThomThomson
added a commit
to ThomThomson/kibana
that referenced
this pull request
Jan 25, 2021
… from listing page (elastic#89041)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Vis Editor
Visualization editor issues
release_note:skip
Skip the PR/issue when compiling release notes
v7.11.0
v7.12.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #88749 by resetting the
appLeaveHandler
in a cleanup function.Checklist
Delete any items that are not applicable to this PR.
For maintainers