[ML] Transforms: Fixes available fields for sort options for latest configuration #88617

walterra · 2021-01-18T17:12:13Z

Summary

Fixes the transform preview header to display the heading text in any case and the copy-to-clipboard button for latest configurations (the copy-to-clipboard option for pivot is displayed within the form).
Fix to avoid listing all fields for the sort option for latest configuration and only show date fields
Fixes ambiguous form field labels

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2021-01-18T17:12:16Z

Pinging @elastic/ml-ui (:ml)

peteharverson · 2021-01-18T17:39:29Z

...lic/app/sections/create_transform/components/step_define/hooks/use_latest_function_config.ts

@@ -56,7 +56,8 @@ function getOptions(
    }));

  const sortFieldOptions: Array<EuiComboBoxOptionOption<string>> = indexPattern.fields
-    .filter((v) => !ignoreFieldNames.has(v.name) && v.sortable)
+    // The backend API for `latest` allows all field types for sort but the UI will be limited to `date`.
+    .filter((v) => !ignoreFieldNames.has(v.name) && v.sortable && v.type === 'date')


Any ideas what we should do if there are no date fields in the source index?

An alternative solution could be to still make all fields available but group them in the dropdown by field type, with date fields first, then numbers, then keyword.

Something like

date fields @timestamp created_at ---- number fields responsetime ---- other airline

Screenshot of the grouped dropdown from EUI docs:

As discussed, let's stick to the current implementation and only show date type fields in the dropdown. Advanced users can switch to the API or dev tools if they really want to use a number field say. And add some help text below the Sort field input, along the lines of Select the date field to be used to identify the latest document.

That text sounds fine to me. I wonder if we can alternatively change the "Add a sort field...." text in the screenshot to "Add a date field ...." and maybe even "...that identifies the latest documents" if space allows.

...ansform/public/app/sections/create_transform/components/step_define/latest_function_form.tsx

Co-authored-by: Lisa Cawley <[email protected]>

...ansform/public/app/sections/create_transform/components/step_define/latest_function_form.tsx

darnautov · 2021-01-20T09:28:51Z

...s/transform/public/app/sections/create_transform/components/step_define/step_define_form.tsx

+            copyToClipboard={copyToClipboardPivot}
+            copyToClipboardDescription={copyToClipboardPivotDescription}


Did you consider passing the "Copy to clipboard" component as a child instead of adding extra props?

It's the same prop structure how we pass it on to DataGrid so didn't want to change that for this PR.

walterra · 2021-01-20T13:42:58Z

Changed latestConfigMapper.toAPIConfig() to return partial configs similar to pivots so a user can copy a config which is not complete (e.g. if no date field for sort is available) to the clipboard to continue in Dev Console. That required to update validateLatestConfig too. I added some jest tests to cover the changes.

walterra · 2021-01-20T13:49:41Z

@lcawl thanks for the feedback, updated the texts.

peteharverson

Tested latest edits and LGTM

kibanamachine · 2021-01-20T15:58:25Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 422355e

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`ml`	7.1MB	7.1MB	+57.0B
`transform`	1.0MB	1.0MB	+2.3KB
total			+2.3KB

History

💚 Build #99670 succeeded dccdfdf
💚 Build #99620 succeeded 64ea3db
💚 Build #99577 succeeded 301960f
💚 Build #99463 succeeded b55d78b
💔 Build #99453 failed 7b22c2b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

darnautov

LGTM

…onfiguration (elastic#88617) - Fixes the transform preview header to display the heading text in any case and the copy-to-clipboard button for latest configurations (the copy-to-clipboard option for pivot is displayed within the form). - Fix to avoid listing all fields for the sort option for latest configuration and only show date fields - Fixes ambiguous form field labels

…onfiguration (#88617) (#88934) - Fixes the transform preview header to display the heading text in any case and the copy-to-clipboard button for latest configurations (the copy-to-clipboard option for pivot is displayed within the form). - Fix to avoid listing all fields for the sort option for latest configuration and only show date fields - Fixes ambiguous form field labels

…onfiguration (#88617) (#88933) - Fixes the transform preview header to display the heading text in any case and the copy-to-clipboard button for latest configurations (the copy-to-clipboard option for pivot is displayed within the form). - Fix to avoid listing all fields for the sort option for latest configuration and only show date fields - Fixes ambiguous form field labels

walterra added 3 commits January 18, 2021 17:42

[ML] Fix transform preview header.

62fe561

[ML] Fixes ambiguous form labels.

bb52fb7

[ML] Fix sort field dropdown filtering.

7b22c2b

walterra added bug Fixes for quality problems that affect the customer experience :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Transforms ML transforms v7.11.0 v7.12.0 labels Jan 18, 2021

walterra requested a review from peteharverson January 18, 2021 17:12

walterra self-assigned this Jan 18, 2021

walterra requested a review from a team as a code owner January 18, 2021 17:12

peteharverson reviewed Jan 18, 2021

View reviewed changes

walterra added 3 commits January 18, 2021 18:54

[ML] Fix translations.

b55d78b

[ML] Display callout when no date field is available.

301960f

[ML] Adds help text for sort field.

64ea3db

peteharverson reviewed Jan 19, 2021

View reviewed changes

...ansform/public/app/sections/create_transform/components/step_define/latest_function_form.tsx Show resolved Hide resolved

lcawl reviewed Jan 19, 2021

View reviewed changes

...ansform/public/app/sections/create_transform/components/step_define/latest_function_form.tsx Outdated Show resolved Hide resolved

lcawl reviewed Jan 19, 2021

View reviewed changes

...ansform/public/app/sections/create_transform/components/step_define/latest_function_form.tsx Outdated Show resolved Hide resolved

Text tweaks.

dccdfdf

Co-authored-by: Lisa Cawley <[email protected]>

darnautov reviewed Jan 20, 2021

View reviewed changes

...ansform/public/app/sections/create_transform/components/step_define/latest_function_form.tsx Outdated Show resolved Hide resolved

darnautov reviewed Jan 20, 2021

View reviewed changes

walterra added 2 commits January 20, 2021 10:30

Merge branch 'master' into ml-transforms-latest-fix-sort

655d3a8

[Ml] Adds tests. Allows partial latest config to be copied to clipboard.

422355e

peteharverson approved these changes Jan 20, 2021

View reviewed changes

darnautov approved these changes Jan 20, 2021

View reviewed changes

walterra merged commit 922abfa into elastic:master Jan 21, 2021

walterra deleted the ml-transforms-latest-fix-sort branch January 21, 2021 07:12

walterra mentioned this pull request Jan 21, 2021

[7.x] [ML] Transforms: Fixes available fields for sort options for latest configuration (#88617) #88933

Merged

walterra mentioned this pull request Jan 21, 2021

[7.11] [ML] Transforms: Fixes available fields for sort options for latest configuration (#88617) #88934

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Transforms: Fixes available fields for sort options for latest configuration #88617

[ML] Transforms: Fixes available fields for sort options for latest configuration #88617

walterra commented Jan 18, 2021 •

edited

Loading

elasticmachine commented Jan 18, 2021

peteharverson Jan 18, 2021

walterra Jan 18, 2021

peteharverson Jan 19, 2021

lcawl Jan 19, 2021

darnautov Jan 20, 2021

walterra Jan 20, 2021

walterra commented Jan 20, 2021

walterra commented Jan 20, 2021

peteharverson left a comment

kibanamachine commented Jan 20, 2021

darnautov left a comment

		copyToClipboard={copyToClipboardPivot}
		copyToClipboardDescription={copyToClipboardPivotDescription}

[ML] Transforms: Fixes available fields for sort options for latest configuration #88617

[ML] Transforms: Fixes available fields for sort options for latest configuration #88617

Conversation

walterra commented Jan 18, 2021 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented Jan 18, 2021

peteharverson Jan 18, 2021

Choose a reason for hiding this comment

walterra Jan 18, 2021

Choose a reason for hiding this comment

peteharverson Jan 19, 2021

Choose a reason for hiding this comment

lcawl Jan 19, 2021

Choose a reason for hiding this comment

darnautov Jan 20, 2021

Choose a reason for hiding this comment

walterra Jan 20, 2021

Choose a reason for hiding this comment

walterra commented Jan 20, 2021

walterra commented Jan 20, 2021

peteharverson left a comment

Choose a reason for hiding this comment

kibanamachine commented Jan 20, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

History

darnautov left a comment

Choose a reason for hiding this comment

walterra commented Jan 18, 2021 •

edited

Loading