-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[XY Axis] Fix bug on percentiles and percentiles ranks #88576
Conversation
@elasticmachine merge upstream |
|
||
const splitSeriesAccessors = useMemo( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is irrelevant with the bug but it is an improvement to avoid unnecessary renders so I have included it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, changes fix issue. Tested locally on chrome.
@elasticmachine merge upstream |
Pinging @elastic/kibana-app (Team:KibanaApp) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LTGM 👍 . Also tested locally and it works as expected (compared legacy and this fix and they are the same chart)
* [XY Axis] Fix bug on percentiles and percentiles ranks * Add unit tests to renderAllSeries * make it simpler * Minor change on test * Fix license headers Co-authored-by: Kibana Machine <[email protected]>
* [XY Axis] Fix bug on percentiles and percentiles ranks * Add unit tests to renderAllSeries * make it simpler * Minor change on test * Fix license headers Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Summary
Closes #88424. This PR fixes the bug on xy plugin with the percentiles and percentiles ranks. The
renderAllSeries
function returnednull
for these two aggregations and as a result, the chart wasn't rendered with theNo data
message. I have enhanced the function to also work with percentiles.Checklist