-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make toolbar_button a shared component #88386
Conversation
@andreadelrio this is a great idea! I think I know the answer to this question, but for the sake of clarity, this will also be used in the shared embeddable toolbar component as well, correct? |
@ryankeairns That's correct! Once this is in I can send a PR against Catherine's branch. |
⏳ Build in-progress, with failures
Failed CI StepsTo update your PR or re-run it, just comment with: |
@myasonik this one needs your engineering review on behalf of kibana-design |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested Lens and still works as expected - LGTM once green (there seems to be some issue with exporting, it probably makes sense to rename the constants specifically for toolbar button)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andreadelrio !!!
src/plugins/kibana_react/public/toolbar_button/toolbar_button.scss
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving the component to Kibana React LGTM
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test FailuresX-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/rbac_legacy·ts.alerting api integration security and spaces enabled Alerts legacy alerts alerts "before all" hook in "alerts"Standard Out
Stack Trace
X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/rbac_legacy·ts.alerting api integration security and spaces enabled Alerts legacy alerts alerts "after all" hook in "alerts"Standard Out
Stack Trace
X-Pack Alerting API Integration Tests.x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/index·ts.alerting api integration security and spaces enabled Alerts legacy alerts "after all" hook in "legacy alerts"Standard Out
Stack Trace
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
toolbar_button
into a shared component so that it can be easily used in other parts of Kibana.Checklist
Delete any items that are not applicable to this PR.
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorialsFor maintainers