Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove telemetry banner in EMS screenshots test #88096

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Remove telemetry banner in EMS screenshots test #88096

merged 2 commits into from
Jan 13, 2021

Conversation

marius-dr
Copy link
Member

This fixes the flakiness from the scroll bar size between different OSs in screenshots. Dismissing the telemetry banner removes the scroll bar completely from the maps screen.

@marius-dr
Copy link
Member Author

@elasticmachine merge upstream

@marius-dr marius-dr requested review from dmlemeshko and LeeDr January 12, 2021 22:42
marius-dr
marius-dr commented Jan 12, 2021
View reviewed changes
x-pack/test/stack_functional_integration/apps/maps/_maps.ts
const PageObjects = getPageObjects(['maps']);

describe('check Elastic Maps Server', function () {
before(async function () {
await PageObjects.maps.loadSavedMap('EMS Test');
await find.clickByButtonText('Dismiss');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used this since there isn't any data-test-subj for that button. once we add a test to check it works we can add a data-test-subj for it.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@marius-dr marius-dr merged commit a98052b into master Jan 13, 2021
@marius-dr marius-dr deleted the ems_fix branch January 13, 2021 09:29
This was referenced Jan 13, 2021
Merged
Merged
marius-dr added a commit to marius-dr/kibana that referenced this pull request Jan 13, 2021
@marius-dr @kibanamachine
dismiss telemetry banner for ems_test (elastic#88096)
4dc7d92 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 15, 2021
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

3 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

marius-dr added a commit that referenced this pull request Jan 20, 2021
@marius-dr @kibanamachine
dismiss telemetry banner for ems_test (#88096) (#88162)
bd39988 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
marius-dr added a commit that referenced this pull request Jan 20, 2021
@marius-dr @kibanamachine
dismiss telemetry banner for ems_test (#88096) (#88161)
f4e84c3 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlemeshko dmlemeshko dmlemeshko approved these changes

@LeeDr LeeDr Awaiting requested review from LeeDr

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes test-stack-integration v7.11.1 v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marius-dr @kibanamachine @dmlemeshko