Do not embedd credentials into ES URL and enable anonymous tests. #87987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
added
release_note:skip
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
This was referenced Jan 12, 2021
azasypkin
added a commit
to azasypkin/kibana
that referenced
this pull request
Jan 12, 2021
azasypkin
added a commit
to azasypkin/kibana
that referenced
this pull request
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While working on the tests for #87091 I noticed that I forgot to enable anonymous access tests for the scenario when Elasticsearch native anonymous access is used. That also revealed that we incorrectly construct Elasticsearch URL in the test server: we still include super user credentials and these are used if Kibana doesn't specify any credentials.