Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SavedObject export hooks #87807
add SavedObject export hooks #87807
Changes from 11 commits
d9de67f
53996ee
a3702f6
af9523f
0ba9aea
067c3f7
cd4ac17
12871c4
f36534f
df1eb4d
3887dbd
417aff9
ed2fc4b
5434e0f
9cee831
c1f49a2
4f292e9
9ac648f
7c6ee4a
a2c380a
1a33426
912da12
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even with the changes I did in
src/core/server/types.ts
to remove some exports that were only server-side, it seems that we are leaking server-side types to the public definition. This seems caused by the addition ofrequest: KibanaRequest
toSavedObjectExportBaseOptions
, however I don't see this type exported fromserver/types
or imported anywhere fromserver/index
... If someone got better eyes that I do...