-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enterprise Search] Migrate Kibana plugin to TS project references #87683
[Enterprise Search] Migrate Kibana plugin to TS project references #87683
Conversation
Sorry about the ping @elastic/enterprise-search-frontend. Converted this to draft until all our other dependencies add their types. Will request a review once complete. |
Super appreciate you doing this Scotty! FYI that I'm about to add a new PR soon that adds another dependency on Kibana's core |
@elasticmachine merge upstream |
merge conflict between base and head |
@elasticmachine merge upstream |
merge conflict between base and head |
@elasticmachine merge upstream |
merge conflict between base and head |
@constancecchen I believe this is done, would you mind giving it a quick look? |
@constancecchen do you know of another way to get the version here? I'm out of ideas how to get this passing. |
Posted in slack but I think we can get around this by landing this and not rolling our own doc links |
This did not fix the issue
@elasticmachine merge upstream |
ignoring request to update branch, pull request is closed |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wahoo!! Thanks again for doing this Scotty!
…lastic#87683) * [Enterprise Search] Migrate Kibana plugin to TS project references Part of elastic#80508 * Add charts and un-comment added ‘features’ Also alphabetize. * Uncomment recently added security and spaces * Add last remaining reference * Add shared typings to cover svgs * Include package.json for version.ts * REvery adding package.json to include This did not fix the issue * Add correct references
…87683) (#89818) * [Enterprise Search] Migrate Kibana plugin to TS project references Part of #80508 * Add charts and un-comment added ‘features’ Also alphabetize. * Uncomment recently added security and spaces * Add last remaining reference * Add shared typings to cover svgs * Include package.json for version.ts * REvery adding package.json to include This did not fix the issue * Add correct references
Part of #80508.
Reference doc.
Apologies for the messy commit history. Best to just view files changed.