Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Migrate Kibana plugin to TS project references #87683

Merged

Conversation

scottybollinger
Copy link
Contributor

@scottybollinger scottybollinger commented Jan 7, 2021

Part of #80508.

Reference doc.

Apologies for the messy commit history. Best to just view files changed.

@scottybollinger scottybollinger added Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Jan 7, 2021
@scottybollinger scottybollinger requested a review from a team January 7, 2021 17:19
@scottybollinger scottybollinger marked this pull request as draft January 7, 2021 17:35
@scottybollinger
Copy link
Contributor Author

Sorry about the ping @elastic/enterprise-search-frontend. Converted this to draft until all our other dependencies add their types. Will request a review once complete.

@cee-chen
Copy link
Contributor

cee-chen commented Jan 7, 2021

Super appreciate you doing this Scotty!

FYI that I'm about to add a new PR soon that adds another dependency on Kibana's core charts plugin (for App Search's analytics charts). I'll tag you when that PR opens/merges as you can keep this PR updated.

@scottybollinger
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@scottybollinger
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@scottybollinger
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

merge conflict between base and head

@scottybollinger scottybollinger marked this pull request as ready for review January 25, 2021 23:01
@scottybollinger
Copy link
Contributor Author

@constancecchen I believe this is done, would you mind giving it a quick look?

@scottybollinger
Copy link
Contributor Author

scottybollinger commented Jan 26, 2021

@constancecchen do you know of another way to get the version here? I'm out of ideas how to get this passing.

@scottybollinger
Copy link
Contributor Author

Posted in slack but I think we can get around this by landing this and not rolling our own doc links

@scottybollinger
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

ignoring request to update branch, pull request is closed

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wahoo!! Thanks again for doing this Scotty!

@scottybollinger scottybollinger merged commit 5feca52 into elastic:master Jan 29, 2021
scottybollinger added a commit to scottybollinger/kibana that referenced this pull request Jan 30, 2021
…lastic#87683)

* [Enterprise Search] Migrate Kibana plugin to TS project references

Part of elastic#80508

* Add charts and un-comment added ‘features’

Also alphabetize.

* Uncomment recently added security and spaces

* Add last remaining reference

* Add shared typings to cover svgs

* Include package.json for version.ts

* REvery adding package.json to include

This did not fix the issue

* Add correct references
scottybollinger added a commit that referenced this pull request Jan 30, 2021
…87683) (#89818)

* [Enterprise Search] Migrate Kibana plugin to TS project references

Part of #80508

* Add charts and un-comment added ‘features’

Also alphabetize.

* Uncomment recently added security and spaces

* Add last remaining reference

* Add shared typings to cover svgs

* Include package.json for version.ts

* REvery adding package.json to include

This did not fix the issue

* Add correct references
@scottybollinger scottybollinger deleted the scottybollinger/es-ts-refs branch March 11, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Plugins release_note:skip Skip the PR/issue when compiling release notes v7.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants