Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Fix the ability to switch to the ratio alert type #87563

Merged
merged 1 commit into from
Jan 7, 2021
Merged

[Logs UI] Fix the ability to switch to the ratio alert type #87563

merged 1 commit into from
Jan 7, 2021

Conversation

weltenwort
Copy link
Member

@weltenwort weltenwort commented Jan 6, 2021 •
edited
Loading

Summary

This fixes a bug introduced with #86488, which prevents the user from changing the log threshold alert type to ratio.

I'm skipping the release notes, because the bug was not released.

@weltenwort weltenwort added bug Fixes for quality problems that affect the customer experience v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.11.0 v7.12.0 labels Jan 6, 2021
@weltenwort weltenwort added this to the Logs UI 7.11 milestone Jan 6, 2021
@weltenwort weltenwort self-assigned this Jan 6, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.7MB 2.7MB +17.0B

Distributable file count

id before after diff
default 47260 48023 +763

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@weltenwort weltenwort marked this pull request as ready for review January 6, 2021 23:37
@weltenwort weltenwort requested a review from a team as a code owner January 6, 2021 23:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort weltenwort added the release_note:skip Skip the PR/issue when compiling release notes label Jan 6, 2021
@Kerry350 Kerry350 self-requested a review January 7, 2021 12:34
Kerry350
Kerry350 approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue 🙏

@weltenwort weltenwort merged commit f170ce2 into elastic:master Jan 7, 2021
@weltenwort weltenwort deleted the logs-ui-fix-alert-ratio-type-selection branch January 7, 2021 13:58
This was referenced Jan 7, 2021
Merged
Merged
weltenwort added a commit to weltenwort/kibana that referenced this pull request Jan 7, 2021
@weltenwort
[Logs UI] Fix the ability to switch to the ratio alert type (elastic#…
350d067 
…87563)

This fixes a bug introduced with elastic#86488, which prevents the user from changing the log threshold alert type to `ratio`.
weltenwort added a commit that referenced this pull request Jan 7, 2021
@weltenwort
[7.x] [Logs UI] Fix the ability to switch to the ratio alert type (#8…
cf45a92 
…7563) (#87629)

Backports the following commits to 7.x:
 - [Logs UI] Fix the ability to switch to the ratio alert type (#87563)
weltenwort added a commit that referenced this pull request Jan 7, 2021
@weltenwort
[7.11] [Logs UI] Fix the ability to switch to the ratio alert type (#…
332653b 
…87563) (#87630)

Backports the following commits to 7.11:
 - [Logs UI] Fix the ability to switch to the ratio alert type (#87563)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emretanriverdi emretanriverdi emretanriverdi approved these changes

@Kerry350 Kerry350 Kerry350 approved these changes

Assignees

@weltenwort weltenwort

Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.11.0 v7.12.0 v8.0.0
Projects
None yet
Milestone
Logs UI 7.11
Development

Successfully merging this pull request may close these issues.
5 participants
@weltenwort @kibanamachine @elasticmachine @Kerry350 @emretanriverdi