Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ILM] Minor UX improvements #87515

Merged
merged 2 commits into from
Jan 7, 2021
Merged

[ILM] Minor UX improvements #87515

merged 2 commits into from
Jan 7, 2021

Conversation

alisonelizabeth
Copy link
Contributor

This fixes two minor issues in ILM I noticed while testing the 7.11 BC.

  • Adding extra padding between the text and loading error notification
  • Updated the help text for the policy name. We are not doing any validation for the ? character, and it appears valid to create a policy with a ? in the name. We are doing validation for ,.

Screenshots

Before
ilm_callout_before

After
ilm_callout_after

Validation
Screen Shot 2021-01-06 at 11 17 10 AM
Screen Shot 2021-01-06 at 11 17 20 AM

@alisonelizabeth alisonelizabeth added Feature:ILM v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.12.0 labels Jan 6, 2021
@alisonelizabeth alisonelizabeth requested a review from a team as a code owner January 6, 2021 16:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexLifecycleManagement 249.8KB 249.9KB +105.0B

Distributable file count

id before after diff
default 47262 48025 +763

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jloleysens
jloleysens approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alisonelizabeth alisonelizabeth merged commit f4042dd into elastic:master Jan 7, 2021
@alisonelizabeth alisonelizabeth deleted the ilm_fixes branch January 7, 2021 14:48
This was referenced Jan 7, 2021
Merged
Merged
alisonelizabeth added a commit to alisonelizabeth/kibana that referenced this pull request Jan 7, 2021
@alisonelizabeth
[ILM] Minor UX improvements (elastic#87515)
191f848
alisonelizabeth added a commit that referenced this pull request Jan 7, 2021
@alisonelizabeth
[ILM] Minor UX improvements (#87515) (#87640)
3499b8a
alisonelizabeth added a commit that referenced this pull request Jan 7, 2021
@alisonelizabeth
[ILM] Minor UX improvements (#87515) (#87641)
c533245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

@yuliacech yuliacech Awaiting requested review from yuliacech

Assignees
No one assigned
Labels
Feature:ILM release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.11.0 v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alisonelizabeth @elasticmachine @kibanamachine @jloleysens