Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerts] added missing brace theme import #87498

Merged
merged 1 commit into from
Jan 7, 2021
Merged

[Alerts] added missing brace theme import #87498

merged 1 commit into from
Jan 7, 2021

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Jan 6, 2021 •
edited
Loading

Summary

Fix #87248

How to test

Read issue 👆🏻 for instructions

CC @spalger

@jloleysens jloleysens added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.12.0 labels Jan 6, 2021
@jloleysens jloleysens requested a review from a team as a code owner January 6, 2021 14:44
ymao1
ymao1 approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Verified no console error when adding an Index or webhook action to an alert.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
triggersActionsUi 329 330 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.5MB 1.5MB +2.4KB

Distributable file count

id before after diff
default 47262 48025 +763

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit ba20a74 into elastic:master Jan 7, 2021
@jloleysens jloleysens deleted the fix/missing-ace-theme-import branch January 7, 2021 08:42
@jloleysens jloleysens removed the request for review from rashmivkulkarni January 7, 2021 08:42
@jloleysens jloleysens mentioned this pull request Jan 7, 2021
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 7, 2021
@jloleysens
added missing brace theme import (elastic#87498)
1649c06
@jloleysens jloleysens mentioned this pull request Jan 7, 2021
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 7, 2021
@jloleysens
added missing brace theme import (elastic#87498)
2fb1bb3
jloleysens added a commit that referenced this pull request Jan 7, 2021
@jloleysens
added missing brace theme import (#87498) (#87606)
3283ec0
jloleysens added a commit that referenced this pull request Jan 7, 2021
@jloleysens
added missing brace theme import (#87498) (#87605)
b0f8f53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymao1 ymao1 ymao1 approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.11.0 v7.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Console error seen while adding an action type while creating alerts.
3 participants
@jloleysens @kibanamachine @ymao1