Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [logstash] remove "upgrade" functionality now that .logstash is a system index (#87056) #87385

Closed
wants to merge 2 commits into from

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Jan 5, 2021

Backport of #87056. The elasticsearch side was recently backported to 7.x - elastic/elasticsearch#66190

@jbudz jbudz added backport Team:Operations Team label for Operations Team labels Jan 5, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 5, 2021

💔 Build Failed

Failed CI Steps


Test Failures

Jest Integration Tests.src/core/server/saved_objects/migrationsv2/integration_tests.migration actions createIndex resolves right after waiting for an index status to be green if the index already existed

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 1 times on tracked branches: https://github.com/elastic/kibana/issues/86350


Stack Trace

ResponseError: null_pointer_exception
    at onBody (/dev/shm/workspace/kibana/node_modules/@elastic/elasticsearch/lib/Transport.js:333:23)
    at IncomingMessage.onEnd (/dev/shm/workspace/kibana/node_modules/@elastic/elasticsearch/lib/Transport.js:260:11)
    at IncomingMessage.emit (events.js:327:22)
    at endReadableNT (internal/streams/readable.js:1327:12)
    at processTicksAndRejections (internal/process/task_queues.js:80:21)

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
logstash 61 54 -7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
logstash 60.8KB 55.9KB -4.9KB
triggersActionsUi 1.6MB 1.5MB -26.9KB
total -31.8KB

Distributable file count

id before after diff
default 47596 48357 +761

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
logstash 25.9KB 25.6KB -313.0B
triggersActionsUi 162.5KB 162.6KB +102.0B
total -211.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 31 32 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger
Copy link
Contributor

spalger commented Jan 6, 2021

I'll take care of the backport in #87577, thanks!

@spalger spalger closed this Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Operations Team label for Operations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants