[Security Solution][Case] Attach/Sync alert to case: Fix toast messages #87206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnasikas
added
bug
cnasikas
force-pushed
the
case_sync_toaster_messages
branch
from
1383bc9 to
12dba72
Compare
cnasikas
commented
Jan 5, 2021
| @@ -89,7 +70,7 @@ export const useUpdateCase = ({ caseId }: { caseId: string }): UseUpdateCase => | |||
| updateKey, | |||
| updateValue, | |||
| updateCase, | |||
| version, | |||
| caseData, | |||
There was a problem hiding this comment.
We need to know when updating the case if it has alerts. For that reason, we replaced the version with the whole Case object.
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
stephmilovic
approved these changes
Jan 5, 2021
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Jan 6, 2021
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Jan 6, 2021
cnasikas
added a commit
that referenced
this pull request
Jan 6, 2021
cnasikas
added a commit
that referenced
this pull request
Jan 6, 2021
…messages (#87206) (#87443) Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the toaster messages that are being displayed when attaching or synching alerts with cases. Specifically:
Fixes: #85998
Checklist
Delete any items that are not applicable to this PR.
For maintainers