-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] Geo containment latency and concurrent containment fix #86980
Conversation
Pinging @elastic/kibana-gis (Team:Geo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing really jumps out. Some initial comments. Will test a little more, but excited for this fix.
x-pack/plugins/stack_alerts/server/alert_types/geo_containment/geo_containment.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/stack_alerts/server/alert_types/geo_containment/geo_containment.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/stack_alerts/server/alert_types/geo_containment/geo_containment.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/stack_alerts/server/alert_types/geo_containment/tests/geo_containment.test.ts
Show resolved
Hide resolved
…rences more clear
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
…86980) (#89586) Co-authored-by: Kibana Machine <[email protected]>
Within a single interval, if a tracked entity moves into multiple shapes, one movement per new shape entered generates a single alert. The following are how several movements are handled with the changes introduced in this PR:
1a -> 1a (alert) -> 1b (alert)
1a (alert) -> 1b (alert), 1c (alert)
1a (alert) -> 1-OTHER -> 1b (alert)
.1a
and1-OTHER
movements are NOT carried through to next interval1a -> 1-OTHER -> 1a (alert)
. Single1a
movement is carried through to next interval1a (alert) -> 1-OTHER
. No entity 1 movements are carried through to next intervalThis sub-interval tracking fixes concurrent containment issues and should also aide with data latency issues