[APM] transactionType should be required on service-specific endpoints
#86893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/apm-ui (Team:apm) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
dgieselaar
reviewed
Jan 4, 2021
| }: { | ||
| start: number; | ||
| end: number; | ||
| transactionGroups: TransactionGroupWithoutTimeseriesData[]; | ||
| timeseriesData: TransactionGroupTimeseriesData; | ||
| latencyAggregationType: LatencyAggregationType; | ||
| transactionType: string; |
There was a problem hiding this comment.
I think there's still a terms aggregation on transaction.type in the original search that we might not need anymore. Can you have a look? (Might be that we are doing it in other places that can now be removed as well).
There was a problem hiding this comment.
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
dgieselaar
reviewed
Jan 5, 2021
Comment on lines
-129
to
-134
| { | ||
| req: { | ||
| url: `/api/apm/services/foo/transactions/charts/throughput?start=${start}&end=${end}&uiFilters=%7B%22environment%22%3A%22testing%22%7D`, | ||
| }, | ||
| expectForbidden: expect403, | ||
| expectResponse: expect200, |
There was a problem hiding this comment.
Why is this removed? Shouldn't we just add a transaction type?
There was a problem hiding this comment.
the one above already tests with a transaction type:
dgieselaar
approved these changes
Jan 5, 2021
This was referenced Jan 5, 2021
cauemarcondes
added a commit
to cauemarcondes/kibana
that referenced
this pull request
Jan 5, 2021
…nts (elastic#86893) * making transaction type required on some apis * addressing PR comments Co-authored-by: Kibana Machine <[email protected]>
cauemarcondes
added a commit
to cauemarcondes/kibana
that referenced
this pull request
Jan 5, 2021
…nts (elastic#86893) * making transaction type required on some apis * addressing PR comments Co-authored-by: Kibana Machine <[email protected]>
cauemarcondes
added a commit
that referenced
this pull request
Jan 5, 2021
…nts (#86893) (#87316) * making transaction type required on some apis * addressing PR comments Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
cauemarcondes
added a commit
that referenced
this pull request
Jan 5, 2021
…nts (#86893) (#87315) * making transaction type required on some apis * addressing PR comments Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
ogupte
added
the
apm:test-plan-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #84611
Partially fixes this #86614
Fix the duplicate calls on the error_rate api due to the transaction type.