Migrates security solution usage collector es client from legacy to new #86853
Conversation
…than the deprecated legacy client
TinaHeiligers
added
Feature:Telemetry
Team:SIEM
v8.0.0
release_note:skip
TinaHeiligers
changed the title
|
Pinging @elastic/siem (Team:SIEM) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@michaelolo24 would you mind taking a look at these changes or redirect the PR to someone who could please? |
Will do! @rylnd should be in the loop as well |
| @@ -4,12 +4,11 @@ | |||
| * you may not use this file except in compliance with the Elastic License. | |||
| */ | |||
|
|
|||
| import { SearchParams } from 'elasticsearch'; | |||
There was a problem hiding this comment.
Guessing this was an accidental import @rylnd?
There was a problem hiding this comment.
Its use was replaced by the custom RuleSearchParams below!
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
| @@ -4,12 +4,11 @@ | |||
| * you may not use this file except in compliance with the Elastic License. | |||
| */ | |||
|
|
|||
| import { SearchParams } from 'elasticsearch'; | |||
There was a problem hiding this comment.
Its use was replaced by the custom RuleSearchParams below!
| }; | ||
| }; | ||
| } | ||
| interface RuleSearchParams { |
There was a problem hiding this comment.
Nit: since ruleSearchOptions is an internal variable and its type is already constrained by its usage I would be inclined to make its type implicit and remove RuleSearchParams. However, there's nothing wrong with the explicit interface here, either.
There was a problem hiding this comment.
I'll keep it explicit for now and leave it up to your team to remove if that's what you prefer.
…y to new (#86853) (#87237) Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Summary
Updates the security solution usage collector
fetchmethod's elasticsearch client to the new client provided by the usage_collector'sfetchcontext.Part of #86358
Checklist
For maintainers