Avoid printing notify object in lang selector on error #8639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ES is unavailable and we can't get the list of enabled scripting langs we display a notification to the user. We were also accidentally returning that notification object from the service method and displaying its toString representation in the language select drop down. Now we simplay return an empty array so the dropdown is rendered without options. Fixes elastic#8636
|
@thomasneirynck mind giving this a second look while you're in the scripted field area anyway? |
|
LGTM |
elastic-jasper
added a commit
that referenced
this pull request
Nov 3, 2016
Backports PR #8639 **Commit 1:** Avoid printing notify object in lang selector on error When ES is unavailable and we can't get the list of enabled scripting langs we display a notification to the user. We were also accidentally returning that notification object from the service method and displaying its toString representation in the language select drop down. Now we simplay return an empty array so the dropdown is rendered without options. Fixes #8636 * Original sha: 051c554 * Authored by Matthew Bargar <[email protected]> on 2016-10-12T15:25:15Z
Bargs
pushed a commit
that referenced
this pull request
Nov 3, 2016
Backports PR #8639 **Commit 1:** Avoid printing notify object in lang selector on error When ES is unavailable and we can't get the list of enabled scripting langs we display a notification to the user. We were also accidentally returning that notification object from the service method and displaying its toString representation in the language select drop down. Now we simplay return an empty array so the dropdown is rendered without options. Fixes #8636 * Original sha: 051c554 * Authored by Matthew Bargar <[email protected]> on 2016-10-12T15:25:15Z
nreese
pushed a commit
to nreese/kibana
that referenced
this pull request
Nov 10, 2016
When ES is unavailable and we can't get the list of enabled scripting langs we display a notification to the user. We were also accidentally returning that notification object from the service method and displaying its toString representation in the language select drop down. Now we simplay return an empty array so the dropdown is rendered without options. Fixes elastic#8636
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Backports PR elastic#8639 **Commit 1:** Avoid printing notify object in lang selector on error When ES is unavailable and we can't get the list of enabled scripting langs we display a notification to the user. We were also accidentally returning that notification object from the service method and displaying its toString representation in the language select drop down. Now we simplay return an empty array so the dropdown is rendered without options. Fixes elastic#8636 * Original sha: 051c554 * Authored by Matthew Bargar <[email protected]> on 2016-10-12T15:25:15Z Former-commit-id: 6ddafd2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ES is unavailable and we can't get the list of enabled scripting
langs we display a notification to the user. We were also accidentally
returning that notification object from the service method and
displaying its toString representation in the language select drop down.
Now we simplay return an empty array so the dropdown is rendered without
options.
Fixes #8636