[Maps] fix layer style editor is empty for EMS boundaries layer #86280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
nreese
commented
Dec 17, 2020
| if (!this._isMounted || _.isEqual(styleFields, this.state.styleFields)) { | ||
| if ( | ||
| !this._isMounted || | ||
| (_.isEqual(styleFields, this.state.styleFields) && this.state.styleFieldsHelper !== undefined) |
There was a problem hiding this comment.
This was the regression. Editor did not render when styleFieldsHelper is undefined and styleFieldsHelper was not getting set when styleFields was an empty array.
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
thomasneirynck
approved these changes
Dec 17, 2020
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Dec 17, 2020
…tic#86280) * [Maps] fix layer style editor is empty for EMS boundaries layer * remove cruft * tslint
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Dec 17, 2020
…tic#86280) * [Maps] fix layer style editor is empty for EMS boundaries layer * remove cruft * tslint
nreese
added a commit
that referenced
this pull request
Dec 17, 2020
…) (#86392) * [Maps] fix layer style editor is empty for EMS boundaries layer * remove cruft * tslint
nreese
added a commit
that referenced
this pull request
Dec 17, 2020
…) (#86391) * [Maps] fix layer style editor is empty for EMS boundaries layer * remove cruft * tslint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86274
Change is only a single line. Rest is jest test to catch regression