Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics UI] Responsive fixes for Legend Options / Bottom Drawer #86009

Merged
merged 11 commits into from
Jan 6, 2021
Merged

[Metrics UI] Responsive fixes for Legend Options / Bottom Drawer #86009

merged 11 commits into from
Jan 6, 2021

Conversation

katefarrar
Copy link
Contributor

@katefarrar katefarrar commented Dec 15, 2020 •
edited
Loading

Summary

Responsive fixes for Legend Options / Bottom Drawer

Legend Options Popover

  • aligned switches with labels
  • fixed minimum / maximum mis-alignment
  • changed number of colors from 20 to 18 so everything fits within container and is aligned
  • fixed overflow issues

Before:
Screen Shot 2020-12-15 at 11 10 22 AM

Screen Shot 2020-12-15 at 11 13 26 AM

After:
Screen Shot 2020-12-15 at 11 13 12 AM

Screen Shot 2020-12-16 at 1 45 55 PM

Bottom Drawer

  • fixed overlapping history legend with gradient palette
  • fixed history legend width issues
  • history timeline now showing

Before:
Screen Shot 2020-12-15 at 11 14 44 AM

After:
Screen Shot 2020-12-15 at 11 39 14 AM

@katefarrar katefarrar added Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Dec 15, 2020
@katefarrar katefarrar marked this pull request as ready for review December 16, 2020 21:14
@katefarrar katefarrar requested a review from a team as a code owner December 16, 2020 21:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@katefarrar katefarrar changed the title Responsive fixes for Legend Options / Bottom Drawer [Metrics UI] Responsive fixes for Legend Options / Bottom Drawer Dec 16, 2020
phillipb
phillipb approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the PR!

@katefarrar
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.7MB 2.7MB +195.0B

Distributable file count

id before after diff
default 47260 48020 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@katefarrar katefarrar merged commit 086bc58 into elastic:master Jan 6, 2021
@katefarrar katefarrar mentioned this pull request Jan 6, 2021
Merged
katefarrar added a commit to katefarrar/kibana that referenced this pull request Jan 6, 2021
@katefarrar
[Metrics UI] Responsive fixes for Legend Options / Bottom Drawer (ela…
8b441d5 
…stic#86009)

Responsive fixes for Legend Options / Bottom Drawer
@katefarrar katefarrar mentioned this pull request Jan 6, 2021
Merged
katefarrar added a commit to katefarrar/kibana that referenced this pull request Jan 6, 2021
@katefarrar
[Metrics UI] Responsive fixes for Legend Options / Bottom Drawer (ela…
405ab4d 
…stic#86009)

Responsive fixes for Legend Options / Bottom Drawer
katefarrar added a commit that referenced this pull request Jan 6, 2021
@katefarrar
[Metrics UI] Responsive fixes for Legend Options / Bottom Drawer (#86009
9e53880 
) (#87506)

Responsive fixes for Legend Options / Bottom Drawer
katefarrar added a commit that referenced this pull request Jan 6, 2021
@katefarrar
[Metrics UI] Responsive fixes for Legend Options / Bottom Drawer (#86009
0987604 
) (#87505)

Responsive fixes for Legend Options / Bottom Drawer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipb phillipb phillipb approved these changes

Assignees
No one assigned
Labels
Feature:Metrics UI Metrics UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@katefarrar @elasticmachine @kibanamachine @phillipb