Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Service overview: Makes service overview default landing page #85786

Merged
merged 4 commits into from
Dec 14, 2020

Conversation

ogupte
Copy link
Contributor

@ogupte ogupte commented Dec 14, 2020

Closes #81948 by setting the default route for services to the service overview page. Also updates links to the general path which gets redirected according to user settings.

… service overview page

also updates links to the general path which gets redirected according to user settings
@ogupte ogupte requested a review from a team as a code owner December 14, 2020 14:51
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Dec 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a small comment.

@ogupte ogupte merged commit 6017cb5 into elastic:master Dec 14, 2020
ogupte added a commit to ogupte/kibana that referenced this pull request Dec 14, 2020
* Closes elastic#81948 by setting the default route for services to the service overview page
also updates links to the general path which gets redirected according to user settings

* fixes incorrect test names

* Update x-pack/plugins/apm/public/components/app/Main/route_config/index.tsx

Co-authored-by: Cauê Marcondes <[email protected]>

* fixes linting

Co-authored-by: Cauê Marcondes <[email protected]>
ogupte added a commit that referenced this pull request Dec 15, 2020
* Closes #81948 by setting the default route for services to the service overview page
also updates links to the general path which gets redirected according to user settings

* fixes incorrect test names

* Update x-pack/plugins/apm/public/components/app/Main/route_config/index.tsx

Co-authored-by: Cauê Marcondes <[email protected]>

* fixes linting

Co-authored-by: Cauê Marcondes <[email protected]>

Co-authored-by: Cauê Marcondes <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
@sorenlouv sorenlouv changed the title [APM] Makes service overview page default [APM] Service overview: Makes service overview default landing page Dec 18, 2020
@sorenlouv sorenlouv mentioned this pull request Dec 18, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.4MB 5.4MB +271.0B

Distributable file count

id before after diff
default 47129 47889 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar self-assigned this Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Make service overview page the default
5 participants