-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Service overview: Makes service overview default landing page #85786
Merged
ogupte
merged 4 commits into
elastic:master
from
ogupte:apm-81948-service-overview-default-page
Dec 14, 2020
Merged
[APM] Service overview: Makes service overview default landing page #85786
ogupte
merged 4 commits into
elastic:master
from
ogupte:apm-81948-service-overview-default-page
Dec 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… service overview page also updates links to the general path which gets redirected according to user settings
Pinging @elastic/apm-ui (Team:apm) |
x-pack/plugins/apm/public/components/app/Main/route_config/index.tsx
Outdated
Show resolved
Hide resolved
cauemarcondes
approved these changes
Dec 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a small comment.
…ex.tsx Co-authored-by: Cauê Marcondes <[email protected]>
ogupte
added a commit
to ogupte/kibana
that referenced
this pull request
Dec 14, 2020
* Closes elastic#81948 by setting the default route for services to the service overview page also updates links to the general path which gets redirected according to user settings * fixes incorrect test names * Update x-pack/plugins/apm/public/components/app/Main/route_config/index.tsx Co-authored-by: Cauê Marcondes <[email protected]> * fixes linting Co-authored-by: Cauê Marcondes <[email protected]>
ogupte
added a commit
that referenced
this pull request
Dec 15, 2020
* Closes #81948 by setting the default route for services to the service overview page also updates links to the general path which gets redirected according to user settings * fixes incorrect test names * Update x-pack/plugins/apm/public/components/app/Main/route_config/index.tsx Co-authored-by: Cauê Marcondes <[email protected]> * fixes linting Co-authored-by: Cauê Marcondes <[email protected]> Co-authored-by: Cauê Marcondes <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
sorenlouv
changed the title
[APM] Makes service overview page default
[APM] Service overview: Makes service overview default landing page
Dec 18, 2020
Closed
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81948 by setting the default route for services to the service overview page. Also updates links to the general path which gets redirected according to user settings.