Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Service overview: Ensure transactionType is used for by every component #85665

Merged
merged 14 commits into from
Dec 18, 2020
Merged

[APM] Service overview: Ensure transactionType is used for by every component #85665

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4e21dab
Ensure transactionType is used in overview
smith Dec 10, 2020
73116db
fix a sort
smith Dec 10, 2020
f516d49
Merge branch 'master' into nls/ttype
kibanamachine Dec 14, 2020
71ac869
Merge remote-tracking branch 'upstream/master' into nls/ttype
smith Dec 14, 2020
c04b539
Merge remote-tracking branch 'upstream/master' into nls/ttype
smith Dec 15, 2020
a7a4562
Merge remote-tracking branch 'upstream/master' into nls/ttype
smith Dec 15, 2020
4e3152a
test fix
smith Dec 15, 2020
63dc146
Merge remote-tracking branch 'upstream/master' into nls/ttype
smith Dec 15, 2020
a108339
Merge branch 'master' into nls/ttype
kibanamachine Dec 15, 2020
9d96a6f
Merge remote-tracking branch 'upstream/master' into nls/ttype
smith Dec 16, 2020
be7f8d3
Snapshot update
smith Dec 16, 2020
5e74652
Merge branch 'master' into nls/ttype
ogupte Dec 17, 2020
e2de0f7
Merge remote-tracking branch 'upstream/master' into nls/ttype
ogupte Dec 17, 2020
337bf54
adds missing required param transactionType to API test
ogupte Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...m/public/components/app/ErrorGroupOverview/List/__test__/__snapshots__/List.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions x-pack/plugins/apm/public/components/app/service_overview/service_overview.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ describe('ServiceOverview', () => {
isAggregationAccurate: true,
},
'GET /api/apm/services/{serviceName}/dependencies': [],
// eslint-disable-next-line @typescript-eslint/naming-convention
'GET /api/apm/services/{serviceName}/service_overview_instances': [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is eslint complaining about here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Property name GET /api/apm/services/{serviceName}/error_groups must match one of the following formats: camelCase, PascalCase, snake_case, UPPER_CASE

};

jest
Expand Down