Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Add ability to specify CORS accepted origins (#84316) #85570

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

mshustov
Copy link
Contributor

Backports the following commits to 7.x:

* add settings

* update abab package to version with types

* add test case for CORS

* add tests for cors config

* fix jest tests

* add deprecation message

* tweak deprecation

* make test runable on Cloud

* add docs

* fix type error

* add test to throw on invalid URL

* address comments

* Update src/core/server/http/http_config.test.ts

Co-authored-by: Larry Gregory <[email protected]>

* Update docs/setup/settings.asciidoc

Co-authored-by: Brandon Kobel <[email protected]>

* allow kbn-xsrf headers to be set on CORS request

Co-authored-by: Larry Gregory <[email protected]>
Co-authored-by: Brandon Kobel <[email protected]>
# Conflicts:
#	src/core/server/config/deprecation/core_deprecations.ts
#	x-pack/scripts/functional_tests.js
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47340 48100 +760

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit ca97dcd into elastic:7.x Dec 10, 2020
@mshustov mshustov deleted the backport/7.x/pr-84316 branch December 10, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants