Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [GS] add tag and dashboard suggestion results (#85144) #85382

Merged
merged 1 commit into from
Dec 9, 2020

Conversation

pgayvallet
Copy link
Contributor

Backports the following commits to 7.x:

* initial draft

* polish

* fix mocks

* add tests

* tests on suggestions

* add comment

* add FTR tests

* factorize getSearchableTypes

* move to bottom
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
globalSearch 23 24 +1
globalSearchBar 35 37 +2
total +3

Distributable file count

id before after diff
default 47300 48063 +763

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
globalSearch 17.0KB 19.8KB +2.8KB
globalSearchBar 43.5KB 48.7KB +5.2KB
globalSearchProviders 8.8KB 8.8KB +79.0B
lens 52.9KB 52.9KB +39.0B
savedObjectsTagging 48.8KB 49.1KB +305.0B
savedObjectsTaggingOss 8.4KB 8.5KB +95.0B
total +8.5KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 42ee8ba into elastic:7.x Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants