Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@kbn/ui-framework] Removes all but dist files #85347

Merged

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Dec 8, 2020

This package has long since been deprecated and no longer maintained. The only reason it still exists is that not all plugins have migrated away from using the kui classes to EUI. This removes all src and build files as a step forward while maintaining the dist which is what is still consumed. This removes @kbn/ui-framework as a build step during bootstrap and gets us one step closer to removing Grunt.

Related to #82239
Related to #46410

This package has long since been deprecated and no longer maintained.
The only reason it still exists is that not all plugins have migrated
away from using the kui classes to EUI. This removes all src and build
files as a step forward.

Signed-off-by: Tyler Smalley <[email protected]>
@tylersmalley tylersmalley added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v8.0.0 v7.11.0 labels Dec 8, 2020
@tylersmalley tylersmalley requested a review from a team as a code owner December 8, 2020 21:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Kibana-Design)

@tylersmalley tylersmalley added the release_note:skip Skip the PR/issue when compiling release notes label Dec 8, 2020
@tylersmalley
Copy link
Contributor Author

@snide this a good step towards #82239?

@tylersmalley tylersmalley requested review from a team as code owners December 9, 2020 22:44
@tylersmalley tylersmalley mentioned this pull request Dec 9, 2020
8 tasks
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 1.7MB 1.7MB -433.0B

Distributable file count

id before after diff
default 46991 47670 +679
oss 27598 27517 -81

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
upgradeAssistant 60.5KB 60.1KB -433.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked over changes, ran locally and looked against places where KUI was still in use. LGTM.

@tylersmalley tylersmalley merged commit a34cd20 into elastic:master Dec 10, 2020
tylersmalley pushed a commit to tylersmalley/kibana that referenced this pull request Dec 10, 2020
This package has long since been deprecated and no longer maintained.
The only reason it still exists is that not all plugins have migrated
away from using the kui classes to EUI. This removes all src and build
files as a step forward.

Signed-off-by: Tyler Smalley <[email protected]>
# Conflicts:
#	.eslintrc.js
#	packages/kbn-ui-framework/doc_site/src/components/guide_page/guide_page.js
#	yarn.lock
tylersmalley pushed a commit that referenced this pull request Dec 10, 2020
This package has long since been deprecated and no longer maintained.
The only reason it still exists is that not all plugins have migrated
away from using the kui classes to EUI. This removes all src and build
files as a step forward.

Signed-off-by: Tyler Smalley <[email protected]>
# Conflicts:
#	.eslintrc.js
#	packages/kbn-ui-framework/doc_site/src/components/guide_page/guide_page.js
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v7.11.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants