-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Update ES archive used for API tests #85286
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgieselaar
added
Team:APM
All issues that need APM UI Team support
release_note:skip
Skip the PR/issue when compiling release notes
v7.11.0
labels
Dec 8, 2020
Pinging @elastic/apm-ui (Team:apm) |
dgieselaar
changed the title
[APM] Make sure jest script can be run from anywhere
[APM] Update ES archive used for API tests
Dec 8, 2020
ogupte
reviewed
Dec 8, 2020
const indicesWithDocs = | ||
response.body.aggregations?.index.buckets.map( | ||
(bucket) => bucket.key as string | ||
) ?? []; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
ogupte
approved these changes
Dec 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
dgieselaar
added a commit
to dgieselaar/kibana
that referenced
this pull request
Dec 9, 2020
* [APM] Make sure jest script can be run from anywhere * Update archive to 7.11
dgieselaar
added a commit
that referenced
this pull request
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:APM
All issues that need APM UI Team support
v7.11.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the main ES archive with 7.11 data, which includes span metrics.
I've added some optimisations to the export script to only archive indices that have documents matching the given query.
I'm also seeing that there are new snapshots, I'll look into that separately.