[Core] UiSettings Client: inline getRaw, remove deep merge #85027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
chore
Team:Core
mshustov
changed the title
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
This reverts commit a6c9bb3.
|
Pinging @elastic/kibana-core (Team:Core) |
afharo
approved these changes
May 6, 2021
pgayvallet
approved these changes
May 6, 2021
streamich
approved these changes
May 6, 2021
mshustov
added
the
auto-backport
💛 Build succeeded, but was flaky
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
May 7, 2021
…5027) * inline getRow, remove deep merge * make sure uiSettings.getAll returns immutable result * update docs * Revert "update docs" This reverts commit a6c9bb3. * use freeze to speed up the process * apply Alejanro suggestion Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
May 7, 2021
…99566) * inline getRow, remove deep merge * make sure uiSettings.getAll returns immutable result * update docs * Revert "update docs" This reverts commit a6c9bb3. * use freeze to speed up the process * apply Alejanro suggestion Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Mikhail Shustov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #97025
Tested locally:
getAll()duration on master: 20-60msgetAll()duration on branch: 9-19msChecklist