-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Synthetics] Waterfall view #84821
Merged
Merged
[Synthetics] Waterfall view #84821
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a06bfb1
Add a new synthetics step detail page for displaying waterfall data
Kerry350 5d6a44d
Merge remote-tracking branch 'upstream/master' into 80162-step-detail…
Kerry350 5d18257
Type and test tweaks
Kerry350 9d2f76d
Remove prop from experiments with showing icon
Kerry350 c3f6dda
Merge remote-tracking branch 'upstream/master' into 80162-step-detail…
Kerry350 7669f23
Merge remote-tracking branch 'upstream/master' into 80162-step-detail…
Kerry350 f7cfcb1
Merge branch 'master' into 80162-step-detail-page
kibanamachine 149bfe6
Use timings directly from the Agent: https://github.com/elastic/synth…
Kerry350 378af34
Merge branch '80162-step-detail-page' of github.com:Kerry350/kibana i…
Kerry350 36629a0
Merge remote-tracking branch 'upstream/master' into 80162-step-detail…
Kerry350 a2056ca
Amend test and add comments
Kerry350 1e3e5db
Merge remote-tracking branch 'upstream/master' into 80162-step-detail…
Kerry350 ca592f0
Amend route after addition of debug feature
Kerry350 f729bce
Account for axis height in total height calculation so that smaller t…
Kerry350 8701a94
Make sidebar and chart border align and remove datepicker
Kerry350 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
x-pack/plugins/uptime/common/runtime_types/network_events.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
|
||
import * as t from 'io-ts'; | ||
|
||
const NetworkTimingsType = t.type({ | ||
dns_start: t.number, | ||
push_end: t.number, | ||
worker_fetch_start: t.number, | ||
worker_respond_with_settled: t.number, | ||
proxy_end: t.number, | ||
worker_start: t.number, | ||
worker_ready: t.number, | ||
send_end: t.number, | ||
connect_end: t.number, | ||
connect_start: t.number, | ||
send_start: t.number, | ||
proxy_start: t.number, | ||
push_start: t.number, | ||
ssl_end: t.number, | ||
receive_headers_end: t.number, | ||
ssl_start: t.number, | ||
request_time: t.number, | ||
dns_end: t.number, | ||
}); | ||
|
||
export type NetworkTimings = t.TypeOf<typeof NetworkTimingsType>; | ||
|
||
const NetworkEventType = t.intersection([ | ||
t.type({ | ||
timestamp: t.string, | ||
requestSentTime: t.number, | ||
loadEndTime: t.number, | ||
}), | ||
t.partial({ | ||
method: t.string, | ||
url: t.string, | ||
status: t.number, | ||
mimeType: t.string, | ||
requestStartTime: t.number, | ||
timings: NetworkTimingsType, | ||
}), | ||
]); | ||
|
||
export type NetworkEvent = t.TypeOf<typeof NetworkEventType>; | ||
|
||
export const SyntheticsNetworkEventsApiResponseType = t.type({ | ||
events: t.array(NetworkEventType), | ||
}); | ||
|
||
export type SyntheticsNetworkEventsApiResponse = t.TypeOf< | ||
typeof SyntheticsNetworkEventsApiResponseType | ||
>; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
x-pack/plugins/uptime/public/components/common/step_detail_link.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
|
||
import React, { FC } from 'react'; | ||
import { EuiLink } from '@elastic/eui'; | ||
import { Link } from 'react-router-dom'; | ||
|
||
interface StepDetailLinkProps { | ||
/** | ||
* The ID of the check group (the journey run) | ||
*/ | ||
checkGroupId: string; | ||
/** | ||
* The index of the step | ||
*/ | ||
stepIndex: number; | ||
} | ||
|
||
export const StepDetailLink: FC<StepDetailLinkProps> = ({ children, checkGroupId, stepIndex }) => { | ||
const to = `/journey/${checkGroupId}/step/${stepIndex}`; | ||
|
||
return ( | ||
<EuiLink> | ||
<Link data-test-subj={`step-detail-link`} to={to}> | ||
{children} | ||
</Link> | ||
</EuiLink> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This kills the purpose of EuiLink, we have a small utility for these kind of use cases,
can you please use that https://github.com/elastic/kibana/blob/master/x-pack/plugins/uptime/public/components/common/react_router_helpers/link_for_eui.tsx#L55
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can change it. I'd actually copied this style from here: https://github.com/elastic/kibana/blob/master/x-pack/plugins/uptime/public/components/common/monitor_page_link.tsx#L22, so maybe that needs changing too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we should change it there as well. i guess we can create a follow up issue to refactor all places in uptime.