[Enterprise Search] Convert IndexingStatus to use logic for fetching #84710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottybollinger
added
Feature:Plugins
release_note:skip
onComplete is not optional so these if blocks can be consolidated
cee-chen
reviewed
Dec 2, 2020
...lugins/enterprise_search/public/applications/shared/indexing_status/indexing_status_logic.ts
Show resolved
Hide resolved
...lugins/enterprise_search/public/applications/shared/indexing_status/indexing_status_logic.ts
Outdated
Show resolved
Hide resolved
...lugins/enterprise_search/public/applications/shared/indexing_status/indexing_status_logic.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/enterprise_search/public/applications/shared/indexing_status/indexing_status.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
+51
to
+53
| expect(wrapper.find(EuiPanel)).toHaveLength(1); | ||
| expect(wrapper.find(IndexingStatusContent)).toHaveLength(1); | ||
| expect(fetchIndexingStatus).toHaveBeenCalled(); |
There was a problem hiding this comment.
Love how much easier this is to test w/o the render prop!! 🎉
...s/enterprise_search/public/applications/shared/indexing_status/indexing_status_logic.test.ts
Outdated
Show resolved
Hide resolved
...s/enterprise_search/public/applications/shared/indexing_status/indexing_status_logic.test.ts
Outdated
Show resolved
Hide resolved
...s/enterprise_search/public/applications/shared/indexing_status/indexing_status_logic.test.ts
Show resolved
Hide resolved
Co-authored-by: Constance <[email protected]>
Co-authored-by: Constance <[email protected]>
cee-chen
approved these changes
Dec 2, 2020
In ent-search, we use Rails helpers to generate paths. These were in the form of routes.whateverPath(). We passed these method to the IndexingStatus component to generate the app-specific rotues in the shared component. In Kibana, we will not have these generators and should instead pass the path strings directly
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
scottybollinger
added a commit
to scottybollinger/kibana
that referenced
this pull request
Dec 2, 2020
…lastic#84710) * Add IndexingStatusLogic * Replace IndexingStatusFetcher with logic * Refactor out unnecessary conditional onComplete is not optional so these if blocks can be consolidated * Misc styling - destructuring and typing Co-authored-by: Constance <[email protected]> * Misc styling - imports Co-authored-by: Constance <[email protected]> * Remove div * Refactor test * Replace method with string for statusPath In ent-search, we use Rails helpers to generate paths. These were in the form of routes.whateverPath(). We passed these method to the IndexingStatus component to generate the app-specific rotues in the shared component. In Kibana, we will not have these generators and should instead pass the path strings directly Co-authored-by: Constance <[email protected]>
scottybollinger
added a commit
that referenced
this pull request
Dec 2, 2020
…84710) (#84825) * Add IndexingStatusLogic * Replace IndexingStatusFetcher with logic * Refactor out unnecessary conditional onComplete is not optional so these if blocks can be consolidated * Misc styling - destructuring and typing Co-authored-by: Constance <[email protected]> * Misc styling - imports Co-authored-by: Constance <[email protected]> * Remove div * Refactor test * Replace method with string for statusPath In ent-search, we use Rails helpers to generate paths. These were in the form of routes.whateverPath(). We passed these method to the IndexingStatus component to generate the app-specific rotues in the shared component. In Kibana, we will not have these generators and should instead pass the path strings directly Co-authored-by: Constance <[email protected]> Co-authored-by: Constance <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR converts the
IndexingStatuscomponent to use a newly added logic file instead of the legacyIndexingStatusFetchercomponent. Because this is the egg and we have no chicken yet, I have pushed a POC of this toent-searchin case QA is desired before merging.Checklist